Page MenuHomePhabricator
Create Task
Maniphest T35184

Links from bookmarked page sometimes open in full screen
Closed, ResolvedPublic
Actions

Description

Bug with the caching; we're missing some event captures or something.

After bookmarking a page, following a wiki link may open in the full window; this breaks back button etc as we end up eating the phonegap app itself. :)

Version: 1.0.0 (Android)
Severity: normal

Details

Reference
bz33184

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:06 AM
• bzimport added a project: Wikipedia-App-Generic.
• bzimport set Reference to bz33184.
• bzimport added a subscriber: Unknown Object (MLST).
• brion created this task.Dec 15 2011, 11:39 PM
• brion added a comment.Dec 15 2011, 11:51 PM

I think this is because of the change to the link event capture; probably can fix with one or both of:

  • change the heavyweight rewrite code to use a <base> like the lightweight rewrite
  • change the internal vs external detector to check for all wikipedia links -- also needed to make it easy to follow inline interwiki links
• brion added a comment.Dec 16 2011, 12:11 AM

[master a8c806a] fix bug 33184 - Links from bookmarked page sometimes open in full screen

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL