Page MenuHomePhabricator
Create Task
Maniphest T351974

Stop showing create an account message on EntitySchema editing UI for Wikibase instances that have temporary accounts enabled
Closed, ResolvedPublic
Actions

Description

Problem:
We are showing warnings when edits are made on EntitySchemas and the user isn't logged in. This warning promps them to create an account or log in. With IP Masking this will no longer be required as we will be deferring to a media wiki status bar: https://phabricator.wikimedia.org/T330510

This should apply to all edits to EntitySchemas.

Example:

image.png (134×325 px, 11 KB)

When editing: https://wikidata.beta.wmflabs.org/wiki/EntitySchema:E10 this warning box appears.

This warning box and message on an EntitySchema page should be removed when editing an EntitySchema and IP masking is enabled and the user isn't logged in.

But the warning should remain as is on wikis that don't have IP masking enabled e.g. 3rd party Wikibases

BDD
GIVEN an EntitySchema
AND a user who isn't logged in
WHEN making an edit
AND IP Masking is enabled
THEN do not show the create an account prompt

Acceptance criteria:

  • Create an account prompt isn't shown when editing EntitySchema when IP Masking is enabled

Notes

It looks like editing EntitySchemas as a temp user seems to be turned off, but will be required to test this.

Related Objects
Search...

Event Timeline

Lydia_Pintscher created this task.Nov 26 2023, 1:05 PM
Lydia_Pintscher added subscribers: ItamarWMDE, Michael.

@ItamarWMDE @Michael I'm not entirely sure what the current state is. Can you help me flesh out this ticket?

Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptNov 26 2023, 1:05 PM
Michael added a comment.Nov 27 2023, 1:10 PM
In T351974#9357702, @Lydia_Pintscher wrote:

@ItamarWMDE @Michael I'm not entirely sure what the current state is. Can you help me flesh out this ticket?

It is still fundamentally unclear to me what team (even WMF<->WMDE) is going to what work in this overall process. Asked more about that at T326908#9359089.

But EntitySchema will need some more fundamental work to create temporary accounts. A WIP/PoC change for Wikibase WIP example: Create a temporary user from ApiSetClaim (I57075e88)

Arian_Bozorg moved this task from Incoming to Product Backlog on the [Archived]Wikidata Dev Team board.Dec 5 2023, 3:15 PM
Arian_Bozorg renamed this task from Support temporary accounts in EntitySchemas to Stop showing IP warning on EntitySchema editing UI for Wikibase instances that have temporary accounts enabled.Jan 12 2024, 2:59 PM
Arian_Bozorg updated the task description. (Show Details)
Arian_Bozorg attached a referenced file: F41537830: image.png. (Show Details)
Arian_Bozorg added a parent task: T354951: Stop showing create an account message on editing UI for Wikibase instances that have temporary accounts enabled.Jan 12 2024, 3:05 PM
Arian_Bozorg renamed this task from Stop showing IP warning on EntitySchema editing UI for Wikibase instances that have temporary accounts enabled to Stop showing create an account message on EntitySchema editing UI for Wikibase instances that have temporary accounts enabled.Jan 17 2024, 11:47 AM
Arian_Bozorg updated the task description. (Show Details)
Arian_Bozorg updated the task description. (Show Details)Jan 17 2024, 11:52 AM
Arian_Bozorg moved this task from Product Backlog to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Jan 17 2024, 11:56 AM
ArthurTaylor added subscribers: Arian_Bozorg, ArthurTaylor.Jan 23 2024, 12:59 PM

@Arian_Bozorg - same question here T354950#9476273

Arian_Bozorg mentioned this in T354950: Stop showing create an account message on Item and property editing UI for Wikibase instances that have temporary accounts enabled.Jan 23 2024, 10:13 PM
Arian_Bozorg added a comment.Jan 23 2024, 10:18 PM

Just adding my response from the other ticket here as well:

With Wikimedia products moving over to Vector 2022, Wikidata will probably make that transition this year as well. This would mean there would be only a small window of time between the temporary accounts and the move to Vector 2022.

So in this case with the login / sign-up warning, let's continue with this ticket and remove them for Wikibase instances that have temporary accounts enabled.

ArthurTaylor claimed this task.Jan 24 2024, 11:41 AM
ArthurTaylor edited projects, added [Archived]Wikidata Dev Team (Wikidata.org Slice); removed [Archived]Wikidata Dev Team.
ArthurTaylor moved this task from In Task Breakdown to Ready for Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
Maintenance_bot moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.Jan 24 2024, 12:29 PM
ArthurTaylor added a comment.Jan 26 2024, 8:09 AM

Hi @Arian_Bozorg ,

I had a look at this, and I'm not able to produce the warning box on beta. Which edit link are you clicking to make that show up?

ArthurTaylor moved this task from Ready for Development to In Task Breakdown on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Jan 26 2024, 8:09 AM
Lucas_Werkmeister_WMDE subscribed.Jan 26 2024, 3:22 PM

As far as I’m aware, the warning shown in

image.png (134×325 px, 11 KB)

doesn’t exist for EntitySchema – Wikibase only shows it for JavaScript editing features, and we don’t really have those for EntitySchema. (Special:SetEntitySchemaLabelDescriptionAliases and action=edit instead have a textual warning that we already removed in T352005.)

Arian_Bozorg closed this task as Resolved.Jan 29 2024, 1:26 AM
Arian_Bozorg moved this task from In Task Breakdown to Done on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Sorry for the oversight, thanks for picking up on that Arthur and for the clarification on that Lucas

ArthurTaylor removed ArthurTaylor as the assignee of this task.Feb 1 2024, 10:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits