Page MenuHomePhabricator

Remember license note confirmation for temporary accounts
Closed, ResolvedPublic

Description

Problem:
We show popups to inform the user that their contributons will be released under a certain license. The user can confirm this to not be bothered about it again. We store this confirmation for IPs and logged-in users but not temporary accounts.

What is currently happening:

image.png (269×323 px, 27 KB)

  • Click "I accept these terms for my future edits. Do not show this message again"
  • Refresh the page
  • Click to edit a statement
  • And the license note will pop up again

What should happen:

With IP Masking we should remember temporary accounts confirmation of the license note so that they are not be bothered each time they make an edit.

If a user who isn't logged in and has temporary accounts enabled clicks "I accept these terms for my future edits. Do not show this message again", we should remember this confirmation and not show the message for them again.

BDD
GIVEN a user who isn't logged in
AND temporary accounts are enabled
AND a License Note
WHEN they accept the license terms
THEN do not show the message again

Acceptance criteria:

  • License notes are no longer shown to users with temporary accounts who have accepted the license terms

Event Timeline

Lydia_Pintscher added a subscriber: Arian_Bozorg.

@Arian_Bozorg Can you help flesh this out please? Thanks!

Lydia_Pintscher renamed this task from Reember license note confirmation for temporary accounts to Remember license note confirmation for temporary accounts.Nov 26 2023, 1:26 PM

Hi @Arian_Bozorg,

I just ran through the reproduction steps here a couple of times, and I am not able to reproduce the bad behaviour. For me, on beta, it seems already to be working as desired. Can we hop on a call so that we can compare reproduction steps?

Looking at this again I am only able to reproduce this on a private browser:

Okay. But I guess that also happens on production the same way for non-logged-in users. Are you suggesting we should implement some kind of tracking so that we can identify the same users over multiple private browsing sessions?

You're right, it seems to be working as we want for temp users, so we can close this one and revisit again in the future if we want to do it on private browsing.

Thanks Arthur