Page MenuHomePhabricator

Revise UserImpactFormatter logic for noPageViewDataYet
Open, LowPublic

Description

Old edited articles without pageviews should not appear in the article list. However due to the changes in the parent task this is now possible, although very rare. The sortAndFilter function expects the json data to contain date-keys for the days with 0 views which is no longer true, see source. It would be nice to revise the logic to make it more robust.

More context:

The changes in 977141 could be slightly changing the articles list output since "old edited" articles with 0 page views would added to recentEditsWithoutPageviews. The problem is rather semantic than breaking the functionality but it could be confusing for uses if they get to see it. Since 0-views edited articles is almost impossible scenario I don't think this is blocker.

Event Timeline

Sgs renamed this task from Revise UserFormatter logic for noPageViewDataYet to Revise UserImpactFormatter logic for noPageViewDataYet.Nov 27 2023, 11:35 AM
Urbanecm_WMF moved this task from Inbox to Triaged on the Growth-Team board.