Page MenuHomePhabricator

Stop showing IP warning on Merge Lexeme for Wikibase instances that have temporary accounts enabled
Closed, ResolvedPublic

Description

Problem:
We are showing warnings on the Merge Lexeme page and the user isn't logged in. This warning informs them that their IP will be shown. With IP Masking this will no longer be the case so we should remove the warning.

Example

image.png (281×1 px, 50 KB)

On the Merge Lexeme page only the IP warning should be removed.
i.e. "Warning: You are not logged in. Your IP address will be publicly visible if you make any edits."

This should only be removed only when IP masking is enabled.

But the warning should remain as is on wikis that don't have IP masking enabled e.g. 3rd party Wikibases

BDD
GIVEN a user who isn't logged in
WHEN merging Lexemes
AND IP Masking is enabled
THEN do not show the IP leak warning

Acceptance criteria:

  • IP leak warning isn't shown on the on the Merge Lexeme page when IP Masking is enabled

Event Timeline

Change 984100 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/WikibaseLexeme@master] Change AnonymousEditWarning to support IP-masking / tempuser

https://gerrit.wikimedia.org/r/984100

Change 984100 abandoned by Arthur taylor:

[mediawiki/extensions/WikibaseLexeme@master] Change AnonymousEditWarning to support IP-masking / tempuser

Reason:

Not needed since I3153030242a3ac597fd7b160897079747c77d648 was merged

https://gerrit.wikimedia.org/r/984100

Change 984210 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove IP warning for anonymous edits on wikis with TempUser

https://gerrit.wikimedia.org/r/984210

Change 984210 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove IP warning for anonymous edits on wikis with TempUser

https://gerrit.wikimedia.org/r/984210

Arian_Bozorg claimed this task.

Looks good to me! Thanks so much :)