Page MenuHomePhabricator

Stop showing IP warning on Merge Item for Wikibase instances that have temporary accounts enabled
Closed, ResolvedPublic

Description

Problem:
We are showing warnings on the Merge Item page and the user isn't logged in. This warning informs them that their IP will be shown. With IP Masking this will no longer be the case so we should remove the warning.

Example

image.png (614×1 px, 82 KB)

On the Merge Item page only the IP warning should be removed
i.e. "Warning: You are not logged in. Your IP address will be publicly visible if you make any edits."

This should only be removed only when IP masking is enabled and the user isn't logged in.

But the warning should remain as is on wikis that don't have IP masking enabled e.g. 3rd party Wikibases

BDD
GIVEN a user who isn't logged in
WHEN merging Items
AND IP Masking is enabled
THEN do not show the IP leak warning

Acceptance criteria:

  • IP leak warning isn't shown on the Merge Item page when IP Masking is enabled

Event Timeline

Change 984210 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove IP warning for anonymous edits on wikis with TempUser

https://gerrit.wikimedia.org/r/984210

Change 984210 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove IP warning for anonymous edits on wikis with TempUser

https://gerrit.wikimedia.org/r/984210

Arian_Bozorg claimed this task.

This looks good to me! Thanks so much :)