Page MenuHomePhabricator

Stop showing IP warning when setting an Item/Property label, description or alias for Wikibase instances that have temporary accounts enabled
Closed, ResolvedPublic

Description

Problem:
We are showing warnings when setting an Item/Property label, description or alias and the user isn't logged in. This warning informs them that their IP will be shown. With IP Masking this will no longer be the case so we should remove the warning.

Example

image.png (357×1 px, 80 KB)

When setting an Item/Property label, description or alias only the IP warning should be removed.
i.e. "Warning: You are not logged in. Your IP address will be publicly visible if you make any edits."

This should only be removed only when IP masking is enabled and the user isn't logged in.

But the warning should remain as is on wikis that don't have IP masking enabled e.g. 3rd party Wikibases

BDD
GIVEN a user who isn't logged in
WHEN setting an Item/Property label, description or alias
AND IP Masking is enabled
THEN do not show the IP leak warning

Acceptance criteria:

Event Timeline

Arian_Bozorg renamed this task from Stop showing IP warning when setting an Item label, description or alias for Wikibase instances that have temporary accounts enabled to Stop showing IP warning when setting an Item/Property label, description or alias for Wikibase instances that have temporary accounts enabled.Dec 15 2023, 11:14 AM
Arian_Bozorg updated the task description. (Show Details)
Arian_Bozorg updated the task description. (Show Details)

Change 984210 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove IP warning for anonymous edits on wikis with TempUser

https://gerrit.wikimedia.org/r/984210

Change 984210 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove IP warning for anonymous edits on wikis with TempUser

https://gerrit.wikimedia.org/r/984210

This change is merged and deployed to beta, but in the configuration on beta, login is required to set item/property labels.

2024-01-02-110030_639x236_scrot.png (236×639 px, 14 KB)

Arian_Bozorg claimed this task.

Thanks so much Arthur, happy to put it through