Page MenuHomePhabricator

Move user-options classes to the MediaWiki\User\Options namespace
Closed, ResolvedPublic

Description

MediaWiki has several classes that are responsible for handling the user options, namely UserOptionsLookup, UserOptionsManager and DefaultOptionsLookup. All of those classes are currently in the MediaWiki\User namespace, making them a bit lost with all the user-related classes.

Since we're adding a new class for conditional user defaults as part of T321527: Support conditional defaults for user properties, let's make the classes to the (already existing) MediaWiki\User\Options namespace, to make the code a bit more organised. Splitting this process to a new task, since it involves a lot of patches (actually renaming in core and changing the class names in all extensions/skins that make use of it).

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/CampaignEventsmaster+4 -2
mediawiki/extensions/Translatemaster+5 -4
mediawiki/coremaster+5 -14
mediawiki/extensions/Translatemaster+2 -2
mediawiki/extensions/EntitySchemamaster+2 -2
mediawiki/extensions/Wikibasemaster+1 -1
mediawiki/extensions/GrowthExperimentsmaster+8 -8
mediawiki/extensions/GrowthExperimentsmaster+1 -1
mediawiki/extensions/Wikibasemaster+2 -2
mediawiki/extensions/CirrusSearchmaster+5 -5
mediawiki/extensions/MobileFrontendmaster+3 -3
mediawiki/extensions/Wikibasemaster+7 -7
mediawiki/extensions/GrowthExperimentsmaster+5 -5
mediawiki/extensions/TwoColConflictmaster+2 -2
mediawiki/extensions/DiscussionToolsmaster+2 -2
mediawiki/extensions/BetaFeaturesmaster+1 -1
mediawiki/extensions/ImageSuggestionsmaster+1 -1
mediawiki/extensions/Citemaster+2 -2
mediawiki/extensions/FileImportermaster+1 -1
mediawiki/extensions/RevisionSlidermaster+2 -2
mediawiki/extensions/TwoColConflictmaster+3 -4
mediawiki/extensions/CheckUsermaster+1 -1
mediawiki/extensions/FileImportermaster+3 -3
mediawiki/extensions/Mathmaster+3 -3
mediawiki/extensions/RealMemaster+3 -3
mediawiki/extensions/RevisionSlidermaster+2 -2
mediawiki/extensions/GlobalWatchlistmaster+2 -2
mediawiki/extensions/MassMessagemaster+2 -2
mediawiki/extensions/CodeMirrormaster+3 -3
mediawiki/extensions/UniversalLanguageSelectormaster+1 -1
mediawiki/extensions/PageTriagemaster+2 -2
mediawiki/extensions/CodeEditormaster+2 -2
mediawiki/extensions/Wikistoriesmaster+3 -3
mediawiki/extensions/MediaSearchmaster+2 -2
mediawiki/extensions/IPInfomaster+11 -11
mediawiki/extensions/MobileFrontendmaster+5 -5
mediawiki/extensions/UniversalLanguageSelectormaster+18 -6
mediawiki/coremaster+27 -15
mediawiki/extensions/GlobalPreferencesmaster+3 -3
mediawiki/extensions/WikimediaMessagesmaster+2 -2
mediawiki/extensions/ContentTranslationmaster+2 -2
mediawiki/extensions/CirrusSearchmaster+5 -5
mediawiki/extensions/ContactPagemaster+2 -2
mediawiki/extensions/PageImagesmaster+2 -2
mediawiki/extensions/EventLoggingmaster+2 -2
mediawiki/extensions/MultimediaViewermaster+2 -2
mediawiki/extensions/SecurePollmaster+4 -4
mediawiki/extensions/PagedTiffHandlermaster+2 -2
mediawiki/extensions/Popupsmaster+4 -3
mediawiki/extensions/ProofreadPagemaster+2 -2
mediawiki/extensions/UploadWizardmaster+2 -2
mediawiki/extensions/WikiEditormaster+2 -2
mediawiki/extensions/VisualEditormaster+1 -1
mediawiki/extensions/WikimediaIncubatormaster+3 -3
mediawiki/extensions/Echomaster+4 -4
mediawiki/extensions/ImageSuggestionsmaster+3 -3
mediawiki/extensions/Echomaster+5 -5
mediawiki/extensions/GlobalPreferencesmaster+5 -5
mediawiki/extensions/Citemaster+2 -2
mediawiki/extensions/WikimediaIncubatormaster+2 -2
mediawiki/extensions/WikiLovemaster+2 -2
mediawiki/extensions/CentralAuthmaster+1 -1
mediawiki/extensions/wikihieromaster+2 -2
mediawiki/extensions/GlobalWatchlistmaster+3 -3
mediawiki/coremaster+146 -119
mediawiki/skins/Vectormaster+1 -1
mediawiki/extensions/TranslationNotificationsmaster+3 -3
mediawiki/extensions/Popupsmaster+3 -3
mediawiki/extensions/AdvancedSearchmaster+2 -2
mediawiki/extensions/CheckUsermaster+15 -9
mediawiki/skins/MinervaNeuemaster+30 -28
mediawiki/skins/Vectormaster+7 -5
mediawiki/extensions/Translatemaster+4 -4
mediawiki/extensions/BetaFeaturesmaster+2 -2
mediawiki/extensions/CampaignEventsmaster+4 -4
mediawiki/extensions/Gadgetsmaster+2 -1
mediawiki/extensions/DiscussionToolsmaster+1 -1
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 978173 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978173

Change 978575 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978575

Change 978574 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978574

Change 978576 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978576

Change 978172 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978172

Change 978579 abandoned by Sergio Gimeno:

[mediawiki/extensions/DiscussionTools@master] Update UserOptionsManager's FQN

Reason:

No replacement is needed, the class name is only mentioned in a comment.

https://gerrit.wikimedia.org/r/978579

Change 978174 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978174

Change 978595 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978595

Change 978588 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978588

Change 978577 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978577

Change 978583 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978583

Change 978176 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978176

Change 978590 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978590

Change 978593 merged by jenkins-bot:

[mediawiki/extensions/WikimediaIncubator@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978593

Change 978546 abandoned by Ammarpad:

[mediawiki/extensions/Gadgets@master] Update UserOptionsLookup's FQN

Reason:

false positive

https://gerrit.wikimedia.org/r/978546

Change 978547 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978547

Change 978551 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978551

Change 978573 merged by jenkins-bot:

[mediawiki/extensions/wikihiero@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978573

Change 978569 merged by jenkins-bot:

[mediawiki/extensions/WikiLove@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978569

Change 978580 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978580

Change 978182 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978182

Change 978571 merged by jenkins-bot:

[mediawiki/extensions/WikimediaIncubator@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978571

Change 978567 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978567

Change 978568 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978568

Change 978559 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978559

Change 978566 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978566

Change 978562 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978562

Change 978558 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978558

Change 978557 merged by jenkins-bot:

[mediawiki/extensions/PagedTiffHandler@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978557

Change 978556 merged by jenkins-bot:

[mediawiki/extensions/PageImages@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978556

Change 978555 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978555

Change 978184 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978184

Change 978179 merged by jenkins-bot:

[mediawiki/extensions/ContactPage@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978179

Change 978175 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978175

Change 978180 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978180

Change 978594 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978594

Change 978641 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] Move StaticUserOptionsLookup to the MediaWiki\User\Options namespace

https://gerrit.wikimedia.org/r/978641

Change 978601 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/BetaFeatures@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978601

Change 978602 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/CirrusSearch@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978602

Change 978603 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Cite@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978603

Change 978604 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/GrowthExperiments@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978604

Change 978605 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/ImageSuggestions@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978605

Change 978646 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/RevisionSlider@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978646

Change 978647 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/TwoColConflict@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978647

Change 978648 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Wikibase@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978648

Change 978582 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978582

Change 978641 merged by jenkins-bot:

[mediawiki/core@master] Move StaticUserOptionsLookup to the MediaWiki\User\Options namespace

https://gerrit.wikimedia.org/r/978641

Change 978554 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978554

Change 978177 merged by jenkins-bot:

[mediawiki/extensions/CodeEditor@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978177

Change 978550 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978550

Change 978572 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978572

Change 978587 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978587

Change 978585 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978585

Change 978178 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978178

Change 978548 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978548

Change 978552 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978552

Change 978553 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978553

Change 978561 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978561

Change 978560 merged by jenkins-bot:

[mediawiki/extensions/RealMe@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978560

Change 978581 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978581

Change 978578 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978578

Change 978646 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978646

Change 978564 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978564

Change 978185 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978185

Change 978603 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978603

Change 978601 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978601

Change 978605 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978605

Change 978181 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978181

Change 978647 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978647

Change 978549 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978549

Change 978570 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978570

Change 978586 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978586

Change 978602 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978602

Change 978592 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978592

Change 978584 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Update UserOptionsManager's FQN

https://gerrit.wikimedia.org/r/978584

Change 978604 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978604

Change 978648 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update StaticUserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978648

Change 978183 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/978183

Let's call this resolved. There are a couple of patches pending, but those are for extensions that keep backwards compatibility for a while.

Change 998922 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] RELEASE-NOTES-1.42: Only need one copy of the User\Options namespacing

https://gerrit.wikimedia.org/r/998922

Change 998922 merged by jenkins-bot:

[mediawiki/core@master] RELEASE-NOTES-1.42: Only need one copy of the User\Options namespacing

https://gerrit.wikimedia.org/r/998922

Change #1027477 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/CampaignEvents@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/1027477

Change #1027478 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Translate@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/1027478

Change #1027478 abandoned by Urbanecm:

[mediawiki/extensions/Translate@master] Update UserOptionsLookup's FQN

Reason:

https://gerrit.wikimedia.org/r/1027478

Change #1027477 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Update UserOptionsLookup's FQN

https://gerrit.wikimedia.org/r/1027477