Page MenuHomePhabricator

UploadWizard - punctuation adjustments
Closed, ResolvedPublic

Description

Split from T352477 (as a follow-up based on this comment T352477#9379215 - the numbering refers to the original ticket).

(1) (from @Sneha's comment in Slack:

all the questions in both own and not own work, show colon at the end of it instead of period. But that is minor and not a blocker.

Screen Shot 2023-11-30 at 9.55.54 AM.png (1×2 px, 317 KB)
Screen Shot 2023-11-30 at 9.55.36 AM.png (1×2 px, 381 KB)

(2) @Sneha's comment

#2 It should match mocks. We should be using the word "work" unless things are referred in plural. The wireframes are updated to reflect that. There are several spots (total 3) in question #1 in someone else's work where we need to change from using "media" to "work"

mockupbeta
Screen Shot 2023-11-30 at 10.02.54 AM.png (1×1 px, 257 KB)
Screen Shot 2023-11-30 at 10.03.24 AM.png (1×2 px, 298 KB)

(3) #1 question "(You may find this information on the page where you found the work.)" the dot in parentheses is missing in beta, but present in the mockup
@Sneha's comment

#3 Yes the period should be there. But also the text needs to be updated from "the media" to "this work"

mockupbeta
Screen Shot 2023-11-30 at 10.11.07 AM.png (428×2 px, 139 KB)
Screen Shot 2023-11-30 at 10.08.51 AM.png (620×2 px, 163 KB)

Event Timeline

(3) #1 question "(You may find this information on the page where you found the work.)" the dot in parentheses is missing in beta, but present in the mockup
@Sneha's comment

#3 Yes the period should be there. But also the text needs to be updated from "the media" to "this work"

mockupbeta
Screen Shot 2023-11-30 at 10.11.07 AM.png (428×2 px, 139 KB)
Screen Shot 2023-11-30 at 10.08.51 AM.png (620×2 px, 163 KB)

FYI: The mockup says "the work", but this comment says "this work". I went with the latter (being the most recent instruction)

Change 980373 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] UI adjustments

https://gerrit.wikimedia.org/r/980373

Highlighting all the copy changes here as some are missing above.

copy changes.png (602×814 px, 87 KB)

@Etonkovidova

Change 980373 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] UI adjustments

https://gerrit.wikimedia.org/r/980373

Punctuation matches the mocks - checked in beta.

Highlighting all the copy changes here as some are missing above.

copy changes.png (602×814 px, 87 KB)

@Etonkovidova

Thx, @Sneha - I checked in beta - "this work" phrase is present according to the specs:

Screen Shot 2023-12-12 at 11.50.20 AM.png (1×1 px, 296 KB)

Etonkovidova claimed this task.

Checked wmf.9 - marking this task as Resolved