Page MenuHomePhabricator
Create Task
Maniphest T352714

PageTriage PHP experimental test errors (postgres, sqlite, php8.2, php8.3)
Open, Needs TriagePublic
Actions

Description

PageTriage experimental build status as of gerrit:982906/6 on Jan 5, 2023:

  • SQLite
    • 1) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testAfcTags - Undefined offset: 0
    • 2) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testMultiAfcCategories - Undefined offset: 0
    • 14) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testAfcTagsAndThatFilter - Failed asserting that actual size 0 matches expected size 1.
    • 15) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testUnsubmittedDrafts - Failed asserting that actual size 0 matches expected size 1.
    • 16) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testFilterType - Mainspace pages that were previously deleted - Failed asserting that two arrays are equal.
    • 17) MediaWiki\Extension\PageTriage\Test\MaintenancePopulateDraftQueueTest::testPreExistingPagesWithCategoriesAreGivenCorrectTags - row #1 mismatches - Failed asserting that two arrays are equal.
    • Failures and errors in other extensions
  • Postgres
    • One MediaWiki-extensions-UserMerge test - MergeUserTest::testMergeOfUserGroups - Wikimedia\Rdbms\DBQueryError: Error 23505: ERROR: duplicate key value violates unique constraint "unittest_user_groups_pkey" - DETAIL: Key (ug_user, ug_group)=(2, group2) already exists.
    • One MediaWiki-extensions-CentralAuth test - 1) MediaWiki\Extension\CentralAuth\Tests\Phpunit\Integration\Special\SpecialGlobalGroupMembershipTest::testSave - Failed asserting that two arrays are equal. (d4bbd1cc)
    • Failures and errors in other extensions
  • PHP 8.2
  • PHP 8.3
  • Node 18
  • Node 20

SQLite

https://integration.wikimedia.org/ci/job/quibble-vendor-sqlite-php74-noselenium-docker/311/consoleFull

14:30:38 1) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testAfcTags
14:30:38 Undefined offset: 0
14:30:38 
14:30:38 /workspace/src/extensions/PageTriage/tests/phpunit/integration/ApiPageTriageListTest.php:89
14:30:38 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 2) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testMultiAfcCategories
14:30:38 Undefined offset: 0
14:30:38 
14:30:38 /workspace/src/extensions/PageTriage/tests/phpunit/integration/ApiPageTriageListTest.php:141
14:30:38 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 --
14:30:38 
14:30:38 There were 17 failures:
14:30:38 
14:30:38 1) ORES\Tests\WatchedItemQueryServiceExtensionTest::testModifyWatchedItemsWithRCInfo
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38  Array (
14:30:38      'oresc_rev' => '1'
14:30:38      'oresc_class' => '1'
14:30:38 -    'oresc_probability' => '0.400'
14:30:38 +    'oresc_probability' => '0.4'
14:30:38      'oresc_model' => '5'
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/includes/Api/WatchedItemQueryServiceExtensionTest.php:175
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 2) ORES\Tests\FetchScoreJobTest::testRun
14:30:38 row #1 mismatches
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38  Array (
14:30:38 -    0 => 17
14:30:38 -    1 => 5
14:30:38 -    2 => 1
14:30:38 -    3 => 0.241
14:30:38 -    4 => 0
14:30:38 +    0 => '17'
14:30:38 +    1 => '5'
14:30:38 +    2 => '1'
14:30:38 +    3 => '0.2405552732802'
14:30:38 +    4 => '0'
14:30:38  )
14:30:38 
14:30:38 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:2294
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/includes/Services/FetchScoreJobTest.php:136
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 3) ORES\Tests\SqlScoreStorageTest::testStoreScoresCleanupOldScores
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38          'oresc_rev' => '567'
14:30:38          'oresc_model' => '3'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.600'
14:30:38 +        'oresc_probability' => '0.6'
14:30:38          'oresc_is_predicted' => '1'
14:30:38      )
14:30:38      2 => stdClass Object (...)
14:30:38 @@ @@
14:30:38          'oresc_rev' => '12345'
14:30:38          'oresc_model' => '1'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.900'
14:30:38 +        'oresc_probability' => '0.9'
14:30:38          'oresc_is_predicted' => '1'
14:30:38      )
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/includes/Storage/SqlScoreStorageTest.php:266
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 4) ORES\Tests\SqlScoreStorageTest::testPurgeRows
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38          'oresc_rev' => '12344'
14:30:38          'oresc_model' => '4'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.860'
14:30:38 +        'oresc_probability' => '0.86'
14:30:38          'oresc_is_predicted' => '1'
14:30:38      )
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/includes/Storage/SqlScoreStorageTest.php:410
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 5) ORES\Tests\Maintenance\PopulateDatabaseTest::testPopulateDatabase with data set #0 (array(stdClass Object (...)), array(array('123')), array(), array())
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38      0 => stdClass Object (
14:30:38          'oresc_rev' => '123'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.320'
14:30:38 +        'oresc_probability' => '0.32'
14:30:38          'oresc_model' => '3'
14:30:38      )
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PopulateDatabaseTest.php:184
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 6) ORES\Tests\Maintenance\PopulateDatabaseTest::testPopulateDatabase with data set #1 (array(stdClass Object (...), stdClass Object (...)), array(array('123'), array('321')), array(array(0.32)), array())
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38      0 => stdClass Object (
14:30:38          'oresc_rev' => '123'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.320'
14:30:38 +        'oresc_probability' => '0.32'
14:30:38          'oresc_model' => '3'
14:30:38      )
14:30:38      1 => stdClass Object (
14:30:38          'oresc_rev' => '321'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.120'
14:30:38 +        'oresc_probability' => '0.12'
14:30:38          'oresc_model' => '3'
14:30:38      )
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PopulateDatabaseTest.php:184
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 7) ORES\Tests\Maintenance\PopulateDatabaseTest::testPopulateDatabase with data set #2 (array(stdClass Object (...)), array(array('123'), array('321')), array(), array('--batch-size', '1', '--number', '1'))
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38      0 => stdClass Object (
14:30:38          'oresc_rev' => '321'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.120'
14:30:38 +        'oresc_probability' => '0.12'
14:30:38          'oresc_model' => '3'
14:30:38      )
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PopulateDatabaseTest.php:184
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 8) ORES\Tests\Maintenance\PopulateDatabaseTest::testPopulateDatabase with data set #3 (array(stdClass Object (...)), array(array('123', '0'), array('321', '1')), array(), array())
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38      0 => stdClass Object (
14:30:38          'oresc_rev' => '123'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.320'
14:30:38 +        'oresc_probability' => '0.32'
14:30:38          'oresc_model' => '3'
14:30:38      )
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PopulateDatabaseTest.php:184
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 9) ORES\Tests\Maintenance\PopulateDatabaseTest::testPopulateDatabase with data set #4 (array(stdClass Object (...), stdClass Object (...)), array(array('123'), array('321')), array(), array('--batch-size', '1'))
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38      0 => stdClass Object (
14:30:38          'oresc_rev' => '123'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.320'
14:30:38 +        'oresc_probability' => '0.32'
14:30:38          'oresc_model' => '3'
14:30:38      )
14:30:38      1 => stdClass Object (
14:30:38          'oresc_rev' => '321'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.120'
14:30:38 +        'oresc_probability' => '0.12'
14:30:38          'oresc_model' => '3'
14:30:38      )
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PopulateDatabaseTest.php:184
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 10) ORES\Tests\Maintenance\PurgeScoreCacheTest::testPurgeScoreCache_bad_model
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38      0 => stdClass Object (
14:30:38          'oresc_rev' => '4922'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.100'
14:30:38 +        'oresc_probability' => '0.1'
14:30:38          'oresc_model' => '3'
14:30:38      )
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PurgeScoreCacheTest.php:70
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 11) ORES\Tests\Maintenance\PurgeScoreCacheTest::testPurgeScoreCache_oldModels
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38      0 => stdClass Object (
14:30:38          'oresc_rev' => '3717'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.100'
14:30:38 +        'oresc_probability' => '0.1'
14:30:38          'oresc_model' => '3'
14:30:38      )
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PurgeScoreCacheTest.php:119
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 12) ORES\Tests\Maintenance\PurgeScoreCacheTest::testPurgeScoreCache_nonRecent
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38      0 => stdClass Object (
14:30:38          'oresc_rev' => '7128'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.100'
14:30:38 +        'oresc_probability' => '0.1'
14:30:38          'oresc_model' => '3'
14:30:38      )
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PurgeScoreCacheTest.php:165
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 13) ORES\Tests\Maintenance\PurgeScoreCacheTest::testPurgeScoreCache_oneModel
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38      0 => stdClass Object (
14:30:38          'oresc_rev' => '4768'
14:30:38          'oresc_class' => '1'
14:30:38 -        'oresc_probability' => '0.100'
14:30:38 +        'oresc_probability' => '0.1'
14:30:38          'oresc_model' => '3'
14:30:38      )
14:30:38  )
14:30:38 
14:30:38 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PurgeScoreCacheTest.php:190
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 14) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testAfcTagsAndThatFilter
14:30:38 Failed asserting that actual size 0 matches expected size 1.
14:30:38 
14:30:38 /workspace/src/extensions/PageTriage/tests/phpunit/integration/ApiPageTriageListTest.php:125
14:30:38 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 15) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testUnsubmittedDrafts
14:30:38 Failed asserting that actual size 0 matches expected size 1.
14:30:38 
14:30:38 /workspace/src/extensions/PageTriage/tests/phpunit/integration/ApiPageTriageListTest.php:171
14:30:38 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 16) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testFilterType
14:30:38 Mainspace pages that were previously deleted
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38  Array (
14:30:38 -    0 => 'PageOther'
14:30:38  )
14:30:38 
14:30:38 /workspace/src/tests/phpunit/MediaWikiTestCaseTrait.php:283
14:30:38 /workspace/src/extensions/PageTriage/tests/phpunit/PageTriageTestCase.php:142
14:30:38 /workspace/src/extensions/PageTriage/tests/phpunit/integration/ApiPageTriageListTest.php:604
14:30:38 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:30:38 
14:30:38 17) MediaWiki\Extension\PageTriage\Test\MaintenancePopulateDraftQueueTest::testPreExistingPagesWithCategoriesAreGivenCorrectTags
14:30:38 row #1 mismatches
14:30:38 Failed asserting that two arrays are equal.
14:30:38 --- Expected
14:30:38 +++ Actual
14:30:38 @@ @@
14:30:38  Array (
14:30:38 -    0 => 5
14:30:38 +    0 => '0'
14:30:38  )
14:30:38 
14:30:38 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:2294
14:30:38 /workspace/src/extensions/PageTriage/tests/phpunit/integration/MaintenancePopulateDraftQueueTest.php:112
14:30:38 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
14:30:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97

Postgres

https://integration.wikimedia.org/ci/job/quibble-vendor-postgres-php74-noselenium-docker/336/consoleFull

14:31:32 1) ORES\Tests\Maintenance\PopulateDatabaseTest::testPopulateDatabase with data set #0 (array(stdClass Object (...)), array(array('123')), array(), array())
14:31:32 Wikimedia\Rdbms\DBQueryError: Error 23505: ERROR:  duplicate key value violates unique constraint "unittest_ores_model_pkey"
14:31:32 DETAIL:  Key (oresm_id)=(1) already exists.
14:31:32 
14:31:32 Function: ORES\Services\ScoreFetcher::updateModelVersion
14:31:32 Query: INSERT INTO "unittest_ores_model" (oresm_name,oresm_version,oresm_is_current) VALUES ('damaging','0.0.4',1)
14:31:32 
14:31:32 
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1200
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1184
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1158
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:649
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1652
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:562
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:136
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:75
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:62
14:31:32 /workspace/src/extensions/ORES/maintenance/PopulateDatabase.php:116
14:31:32 /workspace/src/extensions/ORES/maintenance/PopulateDatabase.php:87
14:31:32 /workspace/src/vendor/wikimedia/testing-access-wrapper/src/TestingAccessWrapper.php:114
14:31:32 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PopulateDatabaseTest.php:176
14:31:32 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:31:32 
14:31:32 2) ORES\Tests\Maintenance\PopulateDatabaseTest::testPopulateDatabase with data set #1 (array(stdClass Object (...), stdClass Object (...)), array(array('123'), array('321')), array(array(0.32)), array())
14:31:32 Wikimedia\Rdbms\DBQueryError: Error 23505: ERROR:  duplicate key value violates unique constraint "unittest_ores_model_pkey"
14:31:32 DETAIL:  Key (oresm_id)=(1) already exists.
14:31:32 
14:31:32 Function: ORES\Services\ScoreFetcher::updateModelVersion
14:31:32 Query: INSERT INTO "unittest_ores_model" (oresm_name,oresm_version,oresm_is_current) VALUES ('damaging','0.0.4',1)
14:31:32 
14:31:32 
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1200
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1184
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1158
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:649
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1652
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:562
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:136
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:75
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:62
14:31:32 /workspace/src/extensions/ORES/maintenance/PopulateDatabase.php:116
14:31:32 /workspace/src/extensions/ORES/maintenance/PopulateDatabase.php:87
14:31:32 /workspace/src/vendor/wikimedia/testing-access-wrapper/src/TestingAccessWrapper.php:114
14:31:32 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PopulateDatabaseTest.php:176
14:31:32 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:31:32 
14:31:32 3) ORES\Tests\Maintenance\PopulateDatabaseTest::testPopulateDatabase with data set #2 (array(stdClass Object (...)), array(array('123'), array('321')), array(), array('--batch-size', '1', '--number', '1'))
14:31:32 Wikimedia\Rdbms\DBQueryError: Error 23505: ERROR:  duplicate key value violates unique constraint "unittest_ores_model_pkey"
14:31:32 DETAIL:  Key (oresm_id)=(1) already exists.
14:31:32 
14:31:32 Function: ORES\Services\ScoreFetcher::updateModelVersion
14:31:32 Query: INSERT INTO "unittest_ores_model" (oresm_name,oresm_version,oresm_is_current) VALUES ('damaging','0.0.4',1)
14:31:32 
14:31:32 
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1200
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1184
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1158
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:649
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1652
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:562
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:136
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:75
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:62
14:31:32 /workspace/src/extensions/ORES/maintenance/PopulateDatabase.php:116
14:31:32 /workspace/src/extensions/ORES/maintenance/PopulateDatabase.php:87
14:31:32 /workspace/src/vendor/wikimedia/testing-access-wrapper/src/TestingAccessWrapper.php:114
14:31:32 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PopulateDatabaseTest.php:176
14:31:32 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:31:32 
14:31:32 4) ORES\Tests\Maintenance\PopulateDatabaseTest::testPopulateDatabase with data set #3 (array(stdClass Object (...)), array(array('123', '0'), array('321', '1')), array(), array())
14:31:32 Wikimedia\Rdbms\DBQueryError: Error 23505: ERROR:  duplicate key value violates unique constraint "unittest_ores_model_pkey"
14:31:32 DETAIL:  Key (oresm_id)=(1) already exists.
14:31:32 
14:31:32 Function: ORES\Services\ScoreFetcher::updateModelVersion
14:31:32 Query: INSERT INTO "unittest_ores_model" (oresm_name,oresm_version,oresm_is_current) VALUES ('damaging','0.0.4',1)
14:31:32 
14:31:32 
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1200
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1184
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1158
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:649
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1652
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:562
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:136
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:75
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:62
14:31:32 /workspace/src/extensions/ORES/maintenance/PopulateDatabase.php:116
14:31:32 /workspace/src/extensions/ORES/maintenance/PopulateDatabase.php:87
14:31:32 /workspace/src/vendor/wikimedia/testing-access-wrapper/src/TestingAccessWrapper.php:114
14:31:32 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PopulateDatabaseTest.php:176
14:31:32 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:31:32 
14:31:32 5) ORES\Tests\Maintenance\PopulateDatabaseTest::testPopulateDatabase with data set #4 (array(stdClass Object (...), stdClass Object (...)), array(array('123'), array('321')), array(), array('--batch-size', '1'))
14:31:32 Wikimedia\Rdbms\DBQueryError: Error 23505: ERROR:  duplicate key value violates unique constraint "unittest_ores_model_pkey"
14:31:32 DETAIL:  Key (oresm_id)=(1) already exists.
14:31:32 
14:31:32 Function: ORES\Services\ScoreFetcher::updateModelVersion
14:31:32 Query: INSERT INTO "unittest_ores_model" (oresm_name,oresm_version,oresm_is_current) VALUES ('damaging','0.0.4',1)
14:31:32 
14:31:32 
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1200
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1184
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1158
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:649
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1652
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:562
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:136
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:75
14:31:32 /workspace/src/extensions/ORES/includes/Services/ScoreFetcher.php:62
14:31:32 /workspace/src/extensions/ORES/maintenance/PopulateDatabase.php:116
14:31:32 /workspace/src/extensions/ORES/maintenance/PopulateDatabase.php:87
14:31:32 /workspace/src/vendor/wikimedia/testing-access-wrapper/src/TestingAccessWrapper.php:114
14:31:32 /workspace/src/extensions/ORES/tests/phpunit/maintenance/PopulateDatabaseTest.php:176
14:31:32 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:31:32 
14:31:32 6) MergeUserTest::testMergeOfUserGroups
14:31:32 Wikimedia\Rdbms\DBQueryError: Error 23505: ERROR:  duplicate key value violates unique constraint "unittest_user_groups_pkey"
14:31:32 DETAIL:  Key (ug_user, ug_group)=(2, group2) already exists.
14:31:32 
14:31:32 Function: MergeUser::mergeDatabaseTables
14:31:32 Query: UPDATE  "unittest_user_groups" SET ug_user = 2 WHERE ug_user = 1
14:31:32 
14:31:32 
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1200
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1184
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1158
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:649
14:31:32 /workspace/src/includes/libs/rdbms/database/Database.php:1485
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
14:31:32 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:413
14:31:32 /workspace/src/extensions/UserMerge/includes/MergeUser.php:338
14:31:32 /workspace/src/extensions/UserMerge/includes/MergeUser.php:56
14:31:32 /workspace/src/extensions/UserMerge/tests/phpunit/MergeUserTest.php:76
14:31:32 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:31:32 
14:31:32 --
14:31:32 
14:31:32 There were 2 failures:
14:31:32 
14:31:32 1) MediaWiki\Extension\CentralAuth\Tests\Phpunit\Integration\Special\SpecialGlobalGroupMembershipTest::testSave
14:31:32 Failed asserting that two arrays are equal.
14:31:32 --- Expected
14:31:32 +++ Actual
14:31:32 @@ @@
14:31:32  Array (
14:31:32 -    0 => 'group-one'
14:31:32 +    0 => 'group-two'
14:31:32      1 => 'group-three'
14:31:32  )
14:31:32 
14:31:32 /workspace/src/extensions/CentralAuth/tests/phpunit/integration/Special/SpecialGlobalGroupMembershipTest.php:292
14:31:32 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

14:31:32 
14:31:32 2) ORES\Tests\Maintenance\PurgeScoreCacheTest::testPurgeScoreCache_all
14:31:32 Failed asserting that 'Purging ORES scores:\n
14:31:32    ...purging scores from all model versions from 'damaging' model': deleted 2 rows\n
14:31:32    ...skipping 'reverted' model, no action needed\n
14:31:32    done.\n
14:31:32 ' matches PCRE pattern "/skipping 'reverted'.+purging scores from all model versions from 'damaging'/s".
14:31:32 
14:31:32 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Cast values for ptrpt_value to stringUmherirrendermediawiki/extensions/PageTriagemaster+8 -8
tests: Call IDatabase::timestamp for postgres in ApiPageTriageListTestUmherirrendermediawiki/extensions/PageTriagemaster+3 -3
tests: Set ptrt_tag_desc when inserting pagetriage_tagsUmherirrendermediawiki/extensions/PageTriagemaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Novem_Linguae created this task.Dec 4 2023, 8:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2023, 8:42 PM
Jdforrester-WMF mentioned this in T353362: Make PHP 8.3 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries).Dec 13 2023, 6:45 PM
Umherirrender subscribed.Dec 13 2023, 6:59 PM

This includes postgres failures (at least the "null value in column "ptrt_tag_desc" violates not-null constraint" seems to be postgres failures)

gerritbot added a comment.Dec 13 2023, 6:59 PM

Change 982900 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageTriage@master] tests: Set ptrt_tag_desc when inserting pagetriage_tags

https://gerrit.wikimedia.org/r/982900

gerritbot added a project: Patch-For-Review.Dec 13 2023, 6:59 PM
Jdforrester-WMF closed this task as Resolved.Dec 13 2023, 9:01 PM
Jdforrester-WMF assigned this task to Umherirrender.
gerritbot added a comment.Dec 13 2023, 9:13 PM

Change 982900 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] tests: Set ptrt_tag_desc when inserting pagetriage_tags

https://gerrit.wikimedia.org/r/982900

Novem_Linguae reopened this task as Open.Dec 13 2023, 9:20 PM
Novem_Linguae removed Umherirrender as the assignee of this task.

Couple more PageTriage ones I think...

(Also tons of ORES ones, but can save that for another ticket)

11:09:55 7) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testAfcTags
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: text = integer
11:09:55 LINE 1: ...e = 150 AND (((ptrpt_tag_id = '1' AND ptrpt_value = 4)))  GR...
11:09:55                                                              ^
11:09:55 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\Api\ApiPageTriageList::getPageIds
11:09:55 Query: SELECT  ptrp_page_id  FROM "unittest_pagetriage_page" JOIN "unittest_page" ON ((ptrp_page_id = page_id)) JOIN "unittest_pagetriage_page_tags" "pagetriage_pt" ON ((pagetriage_pt.ptrpt_page_id = ptrp_page_id))   WHERE (ptrp_reviewed = 0) AND page_namespace = 150 AND (((ptrpt_tag_id = '1' AND ptrpt_value = 4)))  GROUP BY ptrp_page_id HAVING COUNT(*) = 1 ORDER BY ptrp_created DESC, ptrp_page_id DESC LIMIT 21  
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1347
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:351
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageList.php:508
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageList.php:74
11:09:55 /workspace/src/includes/api/ApiMain.php:1931
11:09:55 /workspace/src/includes/api/ApiMain.php:877
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:169
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/PageTriageTestCase.php:95
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/ApiPageTriageListTest.php:66
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

11:09:55 
11:09:55 8) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testAfcTagsAndThatFilter
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: text = integer
11:09:55 LINE 1: ...e = 150 AND (((ptrpt_tag_id = '1' AND ptrpt_value = 4) OR (p...
11:09:55                                                              ^
11:09:55 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\Api\ApiPageTriageList::getPageIds
11:09:55 Query: SELECT  ptrp_page_id  FROM "unittest_pagetriage_page" JOIN "unittest_page" ON ((ptrp_page_id = page_id)) JOIN "unittest_pagetriage_page_tags" "pagetriage_pt" ON ((pagetriage_pt.ptrpt_page_id = ptrp_page_id))   WHERE (ptrp_reviewed = 0) AND page_namespace = 150 AND (((ptrpt_tag_id = '1' AND ptrpt_value = 4) OR (ptrpt_tag_id = '3' AND ptrpt_value = 1)))  GROUP BY ptrp_page_id HAVING COUNT(*) = 2 ORDER BY ptrp_created DESC, ptrp_page_id DESC LIMIT 21  
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1347
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:351
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageList.php:508
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageList.php:74
11:09:55 /workspace/src/includes/api/ApiMain.php:1931
11:09:55 /workspace/src/includes/api/ApiMain.php:877
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:169
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/PageTriageTestCase.php:95
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/ApiPageTriageListTest.php:122
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

11:09:55 
11:09:55 9) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testMultiAfcCategories
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: text = integer
11:09:55 LINE 1: ...e = 150 AND (((ptrpt_tag_id = '1' AND ptrpt_value = 3)))  GR...
11:09:55                                                              ^
11:09:55 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\Api\ApiPageTriageList::getPageIds
11:09:55 Query: SELECT  ptrp_page_id  FROM "unittest_pagetriage_page" JOIN "unittest_page" ON ((ptrp_page_id = page_id)) JOIN "unittest_pagetriage_page_tags" "pagetriage_pt" ON ((pagetriage_pt.ptrpt_page_id = ptrp_page_id))   WHERE (ptrp_reviewed = 0) AND page_namespace = 150 AND (((ptrpt_tag_id = '1' AND ptrpt_value = 3)))  GROUP BY ptrp_page_id HAVING COUNT(*) = 1 ORDER BY ptrp_created DESC, ptrp_page_id DESC LIMIT 21  
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1347
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:351
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageList.php:508
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageList.php:74
11:09:55 /workspace/src/includes/api/ApiMain.php:1931
11:09:55 /workspace/src/includes/api/ApiMain.php:877
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:169
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/PageTriageTestCase.php:95
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/ApiPageTriageListTest.php:139
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

11:09:55 
11:09:55 10) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testUnsubmittedDrafts
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: text = integer
11:09:55 LINE 1: ...e = 150 AND (((ptrpt_tag_id = '1' AND ptrpt_value = 1)))  GR...
11:09:55                                                              ^
11:09:55 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\Api\ApiPageTriageList::getPageIds
11:09:55 Query: SELECT  ptrp_page_id  FROM "unittest_pagetriage_page" JOIN "unittest_page" ON ((ptrp_page_id = page_id)) JOIN "unittest_pagetriage_page_tags" "pagetriage_pt" ON ((pagetriage_pt.ptrpt_page_id = ptrp_page_id))   WHERE (ptrp_reviewed = 0) AND page_namespace = 150 AND (((ptrpt_tag_id = '1' AND ptrpt_value = 1)))  GROUP BY ptrp_page_id HAVING COUNT(*) = 1 ORDER BY ptrp_created DESC, ptrp_page_id DESC LIMIT 21  
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1347
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:351
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageList.php:508
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageList.php:74
11:09:55 /workspace/src/includes/api/ApiMain.php:1931
11:09:55 /workspace/src/includes/api/ApiMain.php:877
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:169
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/PageTriageTestCase.php:95
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/ApiPageTriageListTest.php:162
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

11:09:55 
11:09:55 11) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testSubmissionSorting
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 22008: ERROR:  date/time field value out of range: "20010115000000"
11:09:55 LINE 1: ...test_pagetriage_page" SET ptrp_reviewed_updated = '200101150...
11:09:55                                                              ^
11:09:55 HINT:  Perhaps you need a different "datestyle" setting.
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testSubmissionSorting
11:09:55 Query: UPDATE  "unittest_pagetriage_page" SET ptrp_reviewed_updated = '20010115000000' WHERE ptrp_page_id = 1
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1485
11:09:55 /workspace/src/includes/libs/rdbms/querybuilder/UpdateQueryBuilder.php:332
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/ApiPageTriageListTest.php:343
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

11:09:55 
11:09:55 12) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testFilterDateRange
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 22008: ERROR:  date/time field value out of range: "20190215000000"
11:09:55 LINE 1: ...*/  "unittest_pagetriage_page" SET ptrp_created = '201902150...
11:09:55                                                              ^
11:09:55 HINT:  Perhaps you need a different "datestyle" setting.
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testFilterDateRange
11:09:55 Query: UPDATE  "unittest_pagetriage_page" SET ptrp_created = '20190215000000' WHERE ptrp_page_id = 1
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1485
11:09:55 /workspace/src/includes/libs/rdbms/querybuilder/UpdateQueryBuilder.php:332
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/ApiPageTriageListTest.php:492
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

11:09:55 
11:09:55 13) MediaWiki\Extension\PageTriage\Test\ApiPageTriageListTest::testFilterType
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: text = integer
11:09:55 LINE 1: ...ace = 0 AND (((ptrpt_tag_id = '3' AND ptrpt_value = 1)))  GR...
11:09:55                                                              ^
11:09:55 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\Api\ApiPageTriageList::getPageIds
11:09:55 Query: SELECT  ptrp_page_id  FROM "unittest_pagetriage_page" JOIN "unittest_page" ON ((ptrp_page_id = page_id)) JOIN "unittest_pagetriage_page_tags" "pagetriage_pt" ON ((pagetriage_pt.ptrpt_page_id = ptrp_page_id))   WHERE (ptrp_reviewed = 0) AND page_namespace = 0 AND (((ptrpt_tag_id = '3' AND ptrpt_value = 1)))  GROUP BY ptrp_page_id HAVING COUNT(*) = 1 ORDER BY ptrp_created DESC, ptrp_page_id DESC LIMIT 21  
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1347
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:351
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageList.php:508
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageList.php:74
11:09:55 /workspace/src/includes/api/ApiMain.php:1931
11:09:55 /workspace/src/includes/api/ApiMain.php:877
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:169
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/PageTriageTestCase.php:95
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/ApiPageTriageListTest.php:599
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

11:09:55 
11:09:55 14) MediaWiki\Extension\PageTriage\Test\ApiPageTriageStatsTest::testFilteredArticleCount
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: text = integer
11:09:55 LINE 1: ...e_id))   WHERE ptrpt_tag_id = '1' AND ptrpt_value = 2 AND pa...
11:09:55                                                              ^
11:09:55 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\PageTriageUtil::getUnreviewedDraftStats
11:09:55 Query: SELECT  COUNT(ptrp_page_id) AS total,MIN(ptrp_reviewed_updated) AS oldest  FROM "unittest_page" JOIN "unittest_pagetriage_page" ON ((page_id = ptrp_page_id)) JOIN "unittest_pagetriage_page_tags" ON ((ptrp_page_id = ptrpt_page_id))   WHERE ptrpt_tag_id = '1' AND ptrpt_value = 2 AND page_namespace = 150  LIMIT 1  
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1347
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1356
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:369
11:09:55 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:756
11:09:55 /workspace/src/extensions/PageTriage/includes/PageTriageUtil.php:311
11:09:55 /workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1726
11:09:55 /workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1556
11:09:55 /workspace/src/extensions/PageTriage/includes/PageTriageUtil.php:322
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageStats.php:25
11:09:55 /workspace/src/includes/api/ApiMain.php:1931
11:09:55 /workspace/src/includes/api/ApiMain.php:877
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:169
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/ApiPageTriageStatsTest.php:25
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

11:09:55 
11:09:55 15) MediaWiki\Extension\PageTriage\Test\ApiPageTriageStatsTest::testApiParamsByEndpoint
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: text = integer
11:09:55 LINE 1: ...ace = 0 AND (((ptrpt_tag_id = '3' AND ptrpt_value = 1)))  GR...
11:09:55                                                              ^
11:09:55 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\Api\ApiPageTriageList::getPageIds
11:09:55 Query: SELECT  COUNT(ptrp_page_id) AS total  FROM "unittest_pagetriage_page" JOIN "unittest_page" ON ((ptrp_page_id = page_id)) JOIN "unittest_pagetriage_page_tags" "pagetriage_pt" ON ((pagetriage_pt.ptrpt_page_id = ptrp_page_id))   WHERE (ptrp_reviewed = 0) AND page_namespace = 0 AND (((ptrpt_tag_id = '3' AND ptrpt_value = 1)))  GROUP BY ptrp_page_id HAVING COUNT(*) = 1 LIMIT 1  
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1347
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1356
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:369
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageList.php:492
11:09:55 /workspace/src/extensions/PageTriage/includes/PageTriageUtil.php:190
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageStats.php:24
11:09:55 /workspace/src/includes/api/ApiMain.php:1931
11:09:55 /workspace/src/includes/api/ApiMain.php:877
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:169
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/ApiPageTriageStatsTest.php:57
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

11:09:55 
11:09:55 16) MediaWiki\Extension\PageTriage\Test\ApiPageTriageTagCopyvioTest::testCopyvioInsertLog
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: text = integer
11:09:55 LINE 1: ...age_id = 1 AND ptrpt_tag_id = '4' AND ptrpt_value = 1  LIMIT...
11:09:55                                                              ^
11:09:55 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\Api\ApiPageTriageTagCopyvio::execute
11:09:55 Query: SELECT  ptrpt_page_id  FROM "unittest_pagetriage_page_tags"    WHERE ptrpt_page_id = 1 AND ptrpt_tag_id = '4' AND ptrpt_value = 1  LIMIT 1  
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1347
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1298
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:338
11:09:55 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:726
11:09:55 /workspace/src/extensions/PageTriage/includes/Api/ApiPageTriageTagCopyvio.php:46
11:09:55 /workspace/src/includes/api/ApiMain.php:1931
11:09:55 /workspace/src/includes/api/ApiMain.php:877
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:169
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:209
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/ApiPageTriageTagCopyvioTest.php:84
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

11:09:55 
11:09:55 17) MediaWiki\Extension\PageTriage\Test\MaintenanceCleanupPageTriageTest::testSuccessfulPageTriageCleanup
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 42703: ERROR:  column "0" does not exist
11:09:55 LINE 1: ...ge_id = ptrp_page_id))   WHERE (page_namespace != "0" AND pa...
11:09:55                                                              ^
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\Maintenance\CleanupPageTriage::execute
11:09:55 Query: SELECT  page_id  FROM "unittest_pagetriage_page" JOIN "unittest_page" ON ((page_id = ptrp_page_id))   WHERE (page_namespace != "0" AND page_namespace != "2") AND (ptrp_page_id > 0)  ORDER BY ptrp_page_id LIMIT 100  
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1347
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
11:09:55 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:351
11:09:55 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:708
11:09:55 /workspace/src/extensions/PageTriage/includes/Maintenance/CleanupPageTriage.php:49
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/MaintenanceCleanupPageTriageTest.php:49
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Logs generated by test
Show Details

11:09:55 
11:09:55 18) MediaWiki\Extension\PageTriage\Test\MaintenancePopulateDraftQueueTest::testPreExistingPagesWithCategoriesAreGivenCorrectTags
11:09:55 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: text = integer
11:09:55 LINE 1: ...WHERE ptrt_tag_name = 'afc_state' AND ptrpt_value = 2  LIMIT...
11:09:55                                                              ^
11:09:55 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
11:09:55 
11:09:55 Function: MediaWiki\Extension\PageTriage\Test\MaintenancePopulateDraftQueueTest::testPreExistingPagesWithCategoriesAreGivenCorrectTags
11:09:55 Query: SELECT  COUNT(*)  FROM "unittest_pagetriage_page_tags" JOIN "unittest_pagetriage_tags" ON ((ptrpt_tag_id = ptrt_tag_id))   WHERE ptrt_tag_name = 'afc_state' AND ptrpt_value = 2  LIMIT 1  
11:09:55 
11:09:55 
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1200
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1184
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1158
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:649
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1347
11:09:55 /workspace/src/includes/libs/rdbms/database/Database.php:1298
11:09:55 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:726
11:09:55 /workspace/src/extensions/PageTriage/tests/phpunit/MaintenancePopulateDraftQueueTest.php:75
11:09:55 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
11:09:55 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
Maintenance_bot removed a project: Patch-For-Review.Dec 13 2023, 9:30 PM
Umherirrender renamed this task from PageTriage PHP 8.3 test errors to PageTriage PHP experimental test errors (postgres, sqlite, php8.2, php8.3).Dec 13 2023, 9:35 PM
gerritbot added a comment.Dec 13 2023, 9:35 PM

Change 982906 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageTriage@master] Fix type for database columns

https://gerrit.wikimedia.org/r/982906

gerritbot added a project: Patch-For-Review.Dec 13 2023, 9:35 PM
Umherirrender added a comment.Dec 13 2023, 9:37 PM
In T352714#9404636, @Novem_Linguae wrote:

Couple more PageTriage ones I think...

But not php8.3 ...

Fixing ORES is hard work, you can look at
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ORES/+/814214
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ORES/+/815371
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ORES/+/815366
for some old work from me, but should be own task.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 13 2023, 10:00 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.3 support board.Dec 18 2023, 10:40 PM
Novem_Linguae moved this task from Backlog to Priority technical debt on the PageTriage board.Jan 3 2024, 7:12 PM
Novem_Linguae updated the task description. (Show Details)Jan 7 2024, 2:47 AM
Novem_Linguae added a subtask: T341531: PageTriage PHP unit tests fail on SQLite.Jan 12 2024, 8:49 AM
Novem_Linguae added a subtask: T339132: PageTriage: cleanup dangling test database danglers and remove defensive code in test cases.
gerritbot added a comment.Jan 12 2024, 11:48 AM

Change 990043 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageTriage@master] tests: Call IDatabase::timestamp for postgres in ApiPageTriageListTest

https://gerrit.wikimedia.org/r/990043

gerritbot added a comment.Jan 12 2024, 12:36 PM

Change 990043 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] tests: Call IDatabase::timestamp for postgres in ApiPageTriageListTest

https://gerrit.wikimedia.org/r/990043

ReleaseTaggerBot edited projects, added: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16); removed: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Jan 12 2024, 1:00 PM
gerritbot added a comment.Jan 12 2024, 1:33 PM

Change 982906 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Cast values for ptrpt_value to string

https://gerrit.wikimedia.org/r/982906

Maintenance_bot removed a project: Patch-For-Review.Jan 12 2024, 2:30 PM
Umherirrender closed subtask T339132: PageTriage: cleanup dangling test database danglers and remove defensive code in test cases as Resolved.Jan 12 2024, 5:53 PM
Umherirrender updated the task description. (Show Details)Jan 13 2024, 8:35 PM
Umherirrender updated the task description. (Show Details)Jan 20 2024, 9:59 AM
MPGuy2824 updated the task description. (Show Details)Feb 2 2024, 5:56 AM
Novem_Linguae mentioned this in T333534: Add PageTriage to gated extensions.Feb 6 2024, 7:47 PM
Umherirrender unsubscribed.Mar 3 2024, 4:06 PM
Novem_Linguae added a comment.Apr 11 2025, 9:13 PM

Today I had the thought, "maybe we should add a check experimental build step to CI for PageTriage like we have for mediawiki core". MediaWiki Core checks all the experimental builds not for normal CI checking, but for the "gate and submit" step.

It would make sense to do this for PageTriage if we have eliminated all the check experimental errors and want to keep them from creeping back in.

Today I did a DNM patch in PageTriage to test check experimental. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/1099290/3#message-357116053502b252c6f4706efbdf8ab6a2cd9366

Looks like there's a ton of check experimental errors. However they are not in the PageTriage repo, but in other extensions that PageTriage loads / depends on. A quick summary:

  • sqlite
    • ORES - 12 failures, 8 errors
    • WikimediaEvents - 3 failures
    • CheckUser - 1 failure, 1 error
    • Cite - 1 error
    • IPInfo - 8 errors
  • postgres
    • CheckUser - 26 failures
    • GlobalBlocking - 8 failures, 16 errors
    • IPInfo - 1 failure, 11 errors
    • FlaggedRevs - 25 errors
    • WikimediaEvents - 4 errors
  • mysql
    • failed, but unclear why. might just be a random selenium error

The takeaway from this is probably to never ever run MediaWiki extensions using SQLite, which is the default for Docker. Clearly multiple extensions are full of SQLite bugs. Ditto for Postgres. Always use MariaDB, even in Docker: https://www.mediawiki.org/wiki/MediaWiki-Docker/Configuration_recipes/Alternative_databases#MariaDB_(single_database_server)

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptApr 11 2025, 9:13 PM
Novem_Linguae updated the task description. (Show Details)Apr 11 2025, 9:14 PM
• Scardenasmolinar moved this task from Inbox to To be estimated on the Moderator-Tools-Team board.Apr 17 2025, 5:46 PM
• Scardenasmolinar moved this task from To be estimated to Epics on the Moderator-Tools-Team board.Apr 29 2025, 3:22 PM
Samwalton9-WMF moved this task from Epics to Blocked on the Moderator-Tools-Team board.Sep 5 2025, 1:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits