Page MenuHomePhabricator

Cover fedprops product testing sheet tests in test suite
Closed, ResolvedPublic2 Estimated Story Points

Description

Current Situation:

Goal:

Acceptance Criteria:

[optional] Notes:

  • fed props testing from the product sheet does not work anymore
    • there was version sheet of fedprops, the product sheet is probably outdated
  • need to review the current test implementation we have
  • understand what is in the sheet
  • implement what makes sense in order to cover the same functionality

[optional] Open Questions:

Event Timeline

roti_WMDE changed the task status from Open to In Progress.Dec 5 2023, 12:44 PM
roti_WMDE changed the task status from In Progress to Open.Dec 5 2023, 12:59 PM
roti_WMDE set the point value for this task to 5.
RickiJay-WMDE changed the task status from Open to In Progress.Dec 11 2023, 3:06 AM
RickiJay-WMDE claimed this task.
roti_WMDE changed the point value for this task from 5 to 2.
roti_WMDE added a subscriber: RickiJay-WMDE.

As the task description suggests, the product verification sheet's federated properties tab hasn't been used for the past few releases. Moreover, it's not clear what the scenarios that were being tested are. Instead, I reviewed our automated test suite, namely item.ts and prefatching.ts.
I set up a local Wikibase instance with federated properties by manually executing the tests. They seem to adequately cover the basic usage of this feature, including:

  • Creating an item and adding federated properties to it.
  • Ensuring that the item's data is retrievable in json format and not in unsupported formats like TTL and RDF.
  • Validating that the addition and deletion of federated properties are reflected in the item's history page and Wikibase's recent changes.
adee_wmde moved this task from Doing to Done on the Wikibase Suite Team (Sprint-∞) board.