Page MenuHomePhabricator

"Confirm block" checkbox for self-blocks is hard to find
Open, MediumPublic

Description

Annotated screenshot

Special:Block has a "confirm block" checkbox in some circumstances (at least when blocking yourself). This is small and non-obvious at the bottom of a pile of other checkboxes that you usually don't have to push, and is very far away from the big red warning that "You are about to block yourself! Are you sure you want to do that!"

Initially I couldn't tell that I was supposed to check a box and thought I just had to click "Block this user" a second time; after a few times through that I found the checkbox.

Recommendation:

  • replace the checkbox with a button

or

  • put the checkbox next to the warning

Version: 1.20.x
Severity: normal

Attached:

Details

Reference
bz33282

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:02 AM
bzimport set Reference to bz33282.
bzimport added a subscriber: Unknown Object (MLST).
brion created this task.Dec 20 2011, 7:53 PM

Other ideas:

  1. Remove post-submit "error" and checkbox
  2. Normal submit
  3. After submit go to confirmation screen (could be AJAXified to not need a refresh)
  1. Remove post-submit "error" and checkbox
  2. Extend existing JavaScript module to disable the submit button when username matches logged-in user, and add a checkbox next to the submit button "[_] Are you sure you want to block yourself ?"
  1. ..which when ticked would set input.disabled=false

Be nice if whatever solution is chosen could be worked into HTMLForm in some sort of generic way.

happy.melon.wiki wrote:

(In reply to comment #1)

Other ideas:

  1. Remove post-submit "error" and checkbox
  2. Normal submit
  3. After submit go to confirmation screen (could be AJAXified to not need a

refresh)

That's exactly what the current system is; it's just that confirmation screen looks almost exactly the same as the original screen :)

  1. Remove post-submit "error" and checkbox
  2. Extend existing JavaScript module to disable the submit button when username

matches logged-in user, and

So now only admins without javascript can accidentally block themselves? :p

This would certainly work as a JS 'graceful enable' to replace the (inevitably more clunky) web1.0 version.

  1. add a checkbox next to the submit button "[_] Are

you sure you want to block yourself ?" ..which when ticked would set input.disabled=false

It doesn't need to be a checkbox, just a popup confirm/cancel intercepting the form submission.

(In reply to comment #3)

Be nice if whatever solution is chosen could be worked into HTMLForm in some
sort of generic way.

It would be something like $('#somewrapperid input.mw-htmlform-submit').click(interceptFunction) rather than anything particular to HTMLForm. It's already pretty generic, but if you wanted to make it more so, you'd be making jquery plugins for HTMLForms. Mind you, we need to revamp our JS integration with HTMLForm all round, so this might be a good thing to do in that.

Krinkle removed a subscriber: Krinkle.Apr 25 2017, 8:38 PM