Maniphest T352866

Preserve color keywords and short hex notation as-is
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Hokwelum
	Dec 6 2023, 1:31 PM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

Currently, in Less.php, colors are converted to long Hex code.

The current behaviour expected by Lessjs, in which Less.php mirrors parts of its functionality, expects us to leave colors in their original form: Both color keywords and short hex code.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Less_Tree_Color: Remove internal logic for $isTransparentKeyword	mediawiki/libs/less.php	master	+58 -69
	Less_Tree_Color: Preserve color keywords and short hex notation as-is	mediawiki/libs/less.php	master	+84 -83

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T288498 Update less.php port to support Less.js 3.13 behaviours
		Resolved		Hokwelum	T365481 Update less.php port to complete support Less.js 2.5.3 behaviours
		Resolved		Hokwelum	T352866 Preserve color keywords and short hex notation as-is

Event Timeline

Hokwelum created this task.Dec 6 2023, 1:31 PM

CCiufo-WMF moved this task from Inbox to Following on the Design-System-Team board.Dec 7 2023, 2:52 PM

Hokwelum removed projects: Design-System-Team, Technical-Debt, MediaWiki-ResourceLoader.Dec 7 2023, 8:56 PM

Hokwelum removed subscribers: Volker_E, Aklapper, egardner and 6 others.

Hokwelum claimed this task.Dec 7 2023, 9:11 PM

Hokwelum moved this task from Inbox, needs triage to In progress on the MediaWiki-Platform-Team board.Dec 11 2023, 1:53 PM

Change 983215 had a related patch set uploaded (by Hokwelum; author: Hokwelum):

[mediawiki/libs/less.php@master] Preserve color keywords and short hex notation as it is

https://gerrit.wikimedia.org/r/983215

gerritbot added a project: Patch-For-Review.Dec 14 2023, 4:30 PM

Krinkle closed this task as Resolved.Jan 4 2024, 6:44 PM

Krinkle triaged this task as Medium priority.

Change 983215 merged by jenkins-bot:

[mediawiki/libs/less.php@master] Less_Tree_Color: Preserve color keywords and short hex notation as-is

https://gerrit.wikimedia.org/r/983215

Maintenance_bot removed a project: Patch-For-Review.Jan 4 2024, 7:30 PM

Volker_E awarded a token.Jan 4 2024, 10:20 PM

Volker_E rescinded a token.Feb 20 2024, 11:32 AM

Volker_E awarded a token.

pmiazga mentioned this in T362341: Fix failing less-2.5.3/variables.less test.Apr 11 2024, 3:08 PM

pmiazga mentioned this in T362343: Fix failing less-2.5.3/css.less test.Apr 11 2024, 3:15 PM

Krinkle added a parent task: T365481: Update less.php port to complete support Less.js 2.5.3 behaviours.May 21 2024, 2:26 PM

Krinkle removed a parent task: T288498: Update less.php port to support Less.js 3.13 behaviours.

Change #1121728 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/libs/less.php@master] Less_Tree_Color: Remove internal logic for $isTransparentKeyword

https://gerrit.wikimedia.org/r/1121728

gerritbot added a project: Patch-For-Review.Feb 22 2025, 4:15 AM

Change #1121728 merged by jenkins-bot:

[mediawiki/libs/less.php@master] Less_Tree_Color: Remove internal logic for $isTransparentKeyword

https://gerrit.wikimedia.org/r/1121728

Maintenance_bot removed a project: Patch-For-Review.Feb 27 2025, 8:30 AM