Page MenuHomePhabricator
Create Task
Maniphest T352871

Factor user registration loading to LocalUserRegistrationProvider
Closed, ResolvedPublic
Actions

Description

As part of T344694: [IP Masking] Alert temporary accounts 10 days before expiration, UserRegistrationLookup and LocalUserRegistrationProvider classes were added into MediaWiki Core (in order to allow for multiple registration sources). However, the main registration lookup still happens in the mega User object. In this task, we should:

  • Move registration loading to LocalUserRegistrationProvider and soft-deprecate User::getRegistration
  • Replace usages of User::getRegistration
  • Hard-deprecate User::getRegistration in favour of UserRegistrationLookup
  • (Eventually) remove User::getRegistration

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
User: Update class doc to explain UserRegistrationLookupmediawiki/coremaster+25 -5
Use UserRegistrationLookup to get registration datesmediawiki/extensions/GrowthExperimentsmaster+14 -13
Use UserRegistrationLookup to get registration datemediawiki/extensions/CheckUsermaster+3 -3
Use UserRegistrationLookup to get registration datesmediawiki/extensions/AbuseFiltermaster+19 -22
User: Update cache versionmediawiki/coremaster+1 -1
Drop mRegistration from Usermediawiki/coremaster+7 -13
CreateMenteeHelpers: Don't recreate the user to refresh registrationmediawiki/extensions/GrowthExperimentsmaster+0 -3
Update tests to prepare for dropping mRegistration from Usermediawiki/extensions/GrowthExperimentsmaster+5 -2
Factor user registration loading to LocalUserRegistrationProvidermediawiki/coremaster+46 -26
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Dec 6 2023, 3:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2023, 3:03 PM
Urbanecm_WMF moved this task from Inbox to Current Maintenance Focus on the Growth-Team board.Dec 6 2023, 3:03 PM
Urbanecm_WMF mentioned this in T356895: [wmf.17 - testwiki] Impact module: Temporary delay in getting your information.Feb 7 2024, 7:12 PM
gerritbot added a comment.Feb 8 2024, 12:53 AM

Change 998599 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Factor user registration loading to LocalUserRegistrationProvider

https://gerrit.wikimedia.org/r/998599

gerritbot added a project: Patch-For-Review.Feb 8 2024, 12:53 AM
Zabe subscribed.Feb 8 2024, 12:53 AM
Urbanecm_WMF added a comment.Mar 18 2024, 8:12 PM

Hi @Zabe! Thanks so much for starting the work for this! Are you interested in finishing the patch to pass CI? Is there something I can do (or my team can do) to help you with moving this forward?

Zabe added a comment.Mar 18 2024, 9:20 PM

Hey, I got the patch to pass CI now. But I need to say that I have currently no testing setup around. So I would be more than happy if you could review the patch and also roughly test it if thats feasible. Thanks! :)

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Jun 12 2024, 3:40 AM
Urbanecm_WMF edited projects, added Growth-Team (Maintenance); removed Growth-Team.Nov 18 2024, 5:23 PM
Sgs moved this task from Backlog to GrowthExperiments dark mode on the Growth-Team (Maintenance) board.Nov 19 2024, 12:09 PM
Sgs moved this task from GrowthExperiments dark mode to Backlog on the Growth-Team (Maintenance) board.Nov 20 2024, 3:41 PM
DMburugu edited projects, added Growth Team Maintenance; removed Growth-Team (Maintenance).Oct 8 2025, 11:35 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 8 2025, 11:35 AM
mszwarc added a parent task: T408182: Update LocalUserRegistrationProvider to support users from remote wikis.Oct 24 2025, 8:06 AM
mszwarc added a project: Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)).EditedOct 24 2025, 8:37 AM
mszwarc subscribed.

I'm adding this task to our sprint, as we will need getRegistration to be extracted from User in order to proceed with T406544: Create a way to technically enforce policies for restricted groups. It's not immediately needed, but I'll probably look at the proposed patch in the next week, unless it's updated earlier.

mszwarc moved this task from Backlog to Ready on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.Oct 24 2025, 8:47 AM
mszwarc claimed this task.Oct 27 2025, 12:56 PM
mszwarc moved this task from Ready to In progress on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.
gerritbot added a comment.Oct 28 2025, 12:29 AM

Change #998599 merged by jenkins-bot:

[mediawiki/core@master] Factor user registration loading to LocalUserRegistrationProvider

https://gerrit.wikimedia.org/r/998599

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.25; 2025-10-28).Oct 28 2025, 1:00 AM
mszwarc removed a project: Patch-Needs-Improvement.Oct 28 2025, 12:51 PM
gerritbot added a comment.Oct 29 2025, 7:58 AM

Change #1199707 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/GrowthExperiments@master] Update tests to prepare for dropping mRegistration from User

https://gerrit.wikimedia.org/r/1199707

gerritbot added a project: Patch-For-Review.Oct 29 2025, 7:58 AM
gerritbot added a comment.Oct 29 2025, 8:08 AM

Change #1199710 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] Drop mRegistration from User

https://gerrit.wikimedia.org/r/1199710

gerritbot added a comment.Oct 29 2025, 8:15 AM

Change #1199711 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/GrowthExperiments@master] CreateMenteeHelpers: Don't recreate the user to refresh registration

https://gerrit.wikimedia.org/r/1199711

mszwarc moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.Oct 29 2025, 11:34 AM
gerritbot added a comment.Oct 30 2025, 4:44 PM

Change #1199707 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Update tests to prepare for dropping mRegistration from User

https://gerrit.wikimedia.org/r/1199707

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.1; 2025-11-05).Oct 30 2025, 5:00 PM
gerritbot added a comment.Nov 4 2025, 3:36 PM

Change #1199710 merged by jenkins-bot:

[mediawiki/core@master] Drop mRegistration from User

https://gerrit.wikimedia.org/r/1199710

gerritbot added a comment.Nov 4 2025, 3:42 PM

Change #1199711 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] CreateMenteeHelpers: Don't recreate the user to refresh registration

https://gerrit.wikimedia.org/r/1199711

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.2; 2025-11-12); removed MW-1.46-notes (1.46.0-wmf.1; 2025-11-05).Nov 4 2025, 4:00 PM
mszwarc updated the task description. (Show Details)Nov 5 2025, 9:00 AM
gerritbot added a comment.Nov 6 2025, 7:52 AM

Change #1202633 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] User: Update cache version

https://gerrit.wikimedia.org/r/1202633

gerritbot added a comment.Nov 6 2025, 8:59 AM

Change #1202633 merged by jenkins-bot:

[mediawiki/core@master] User: Update cache version

https://gerrit.wikimedia.org/r/1202633

mszwarc moved this task from Needs review to Ready on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.Nov 6 2025, 11:34 AM

Moving back to Ready to reflect that there are no more patches to review at the moment

Tchanders edited projects, added Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)); removed Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)).Nov 10 2025, 11:50 AM
Tchanders moved this task from Backlog to Ready on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.
mszwarc moved this task from Ready to In progress on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.Nov 12 2025, 2:22 PM
mszwarc added a comment.EditedNov 12 2025, 2:49 PM

I went through usages of User::getRegistration() in the WMF-deployed code and I think it's the most important to update the files listed below. They create a full User object only in order to get its registration date. We no longer need to do that.

AbuseFilter:

CheckUser:

GrowthExperiments:

Urbanecm_WMF added a comment.Nov 12 2025, 2:53 PM

@mszwarc Do you plan to upload the code to do this, or should I tackle the Growth-facing parts on our side?

mszwarc added a comment.Nov 12 2025, 2:55 PM
In T352871#11366916, @Urbanecm_WMF wrote:

@mszwarc Do you plan to upload the code to do this, or should I tackle the Growth-facing parts on our side?

Yes, I'll prepare the code, probably tomorrow

Urbanecm_WMF added a comment.Nov 12 2025, 2:55 PM

Okay, feel free to ask me for review on that if needed! Thanks for your work on this.

gerritbot added a comment.Nov 13 2025, 8:51 AM

Change #1204802 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/GrowthExperiments@master] Use UserRegistrationLookup to get regitration dates

https://gerrit.wikimedia.org/r/1204802

gerritbot added a comment.Nov 13 2025, 9:32 AM

Change #1204805 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/AbuseFilter@master] Use UserRegistrationLookup to get registration dates

https://gerrit.wikimedia.org/r/1204805

gerritbot added a comment.Nov 13 2025, 11:11 AM

Change #1204819 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CheckUser@master] Use UserRegistrationLookup to get registration date

https://gerrit.wikimedia.org/r/1204819

gerritbot added a comment.Nov 13 2025, 11:41 AM

Change #1204805 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Use UserRegistrationLookup to get registration dates

https://gerrit.wikimedia.org/r/1204805

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.3; 2025-11-19); removed MW-1.46-notes (1.46.0-wmf.2; 2025-11-12).Nov 13 2025, 12:00 PM
mszwarc moved this task from In progress to Needs review on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.Nov 13 2025, 12:25 PM
gerritbot added a comment.Nov 13 2025, 12:53 PM

Change #1204819 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use UserRegistrationLookup to get registration date

https://gerrit.wikimedia.org/r/1204819

gerritbot added a comment.Nov 14 2025, 12:22 AM

Change #1204987 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] User: Update class doc to explain UserRegistrationLookup

https://gerrit.wikimedia.org/r/1204987

Urbanecm_WMF mentioned this in T410467: Remove the ExportWelcomeSurveyMailingListData maintenance script from GrowthExperiments.Nov 18 2025, 10:40 PM
gerritbot added a comment.Nov 18 2025, 11:06 PM

Change #1204802 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Use UserRegistrationLookup to get registration dates

https://gerrit.wikimedia.org/r/1204802

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.4; 2025-11-25); removed MW-1.46-notes (1.46.0-wmf.3; 2025-11-19).Nov 19 2025, 12:00 AM
mszwarc removed mszwarc as the assignee of this task.Nov 19 2025, 8:18 AM
mszwarc moved this task from Needs review to Done on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.
mszwarc added a project: patch-welcome.

There are still a few usages of User::getRegistration() in the production code. However, as it less and less related to the actual projects the PSI team is working on, I'll unassign myself from this task and stop here. To reflect that, I'm moving this task to the Done column on our sprint board.

Most of the remaining code can be updated by injecting UserRegistrationLookup to the relevant class and then update $user->getRegistration() to $this->userRegistrationLookup->getRegistration( $user ).

It's seems simple enough that I'm tagging it with patch-welcome and I can provide reviews in case the patches arrive.

Michael moved this task from Backlog to Unused code removal & deprecations on the Growth Team Maintenance board.Dec 22 2025, 8:07 PM
gerritbot added a comment.Tue, Jan 13, 2:14 PM

Change #1204987 merged by jenkins-bot:

[mediawiki/core@master] User: Update class doc to explain UserRegistrationLookup

https://gerrit.wikimedia.org/r/1204987

Niharika closed this task as Resolved.Wed, Jan 21, 2:22 PM
Niharika claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits