Calling ReflectionProperty::setValue() for static values is deprecated in php8.3 (used by core's session tests)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Dec 6 2023, 7:47 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Umherirrender

Description

session tests should use TestingAccessWrapper::newFromClass instead of own ReflectionProperty::setValue to benefit from the fix T352060

There were 8 errors:

1) MediaWiki\Session\PHPSessionHandlerTest::testEnableFlags
Calling ReflectionProperty::setValue() with a single argument is deprecated

/workspace/src/vendor/wikimedia/scoped-callback/src/ScopedCallback.php:102

Caused by
Calling ReflectionProperty::setValue() with a single argument is deprecated

/workspace/src/tests/phpunit/includes/session/PHPSessionHandlerTest.php:45

2) MediaWiki\Session\PHPSessionHandlerTest::testInstall
Calling ReflectionProperty::setValue() with a single argument is deprecated

/workspace/src/tests/phpunit/includes/session/PHPSessionHandlerTest.php:67

5) MediaWiki\Session\PHPSessionHandlerTest::testDisabled with data set #0 ('open', array('', ''))
Calling ReflectionProperty::setValue() with a single argument is deprecated

/workspace/src/tests/phpunit/includes/session/PHPSessionHandlerTest.php:318

6) MediaWiki\Session\PHPSessionHandlerTest::testDisabled with data set #1 ('read', array(''))
Calling ReflectionProperty::setValue() with a single argument is deprecated

/workspace/src/tests/phpunit/includes/session/PHPSessionHandlerTest.php:318

7) MediaWiki\Session\PHPSessionHandlerTest::testDisabled with data set #2 ('write', array('', ''))
Calling ReflectionProperty::setValue() with a single argument is deprecated

/workspace/src/tests/phpunit/includes/session/PHPSessionHandlerTest.php:318

8) MediaWiki\Session\PHPSessionHandlerTest::testDisabled with data set #3 ('destroy', array(''))
Calling ReflectionProperty::setValue() with a single argument is deprecated

/workspace/src/tests/phpunit/includes/session/PHPSessionHandlerTest.php:318

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
tests: Use TestingAccessWrapper::newFromClass in session tests	Reedy	mediawiki/core	REL1_40	+42 -55
tests: Use TestingAccessWrapper::newFromClass in session tests	Reedy	mediawiki/core	REL1_39	+42 -55
tests: Use TestingAccessWrapper::newFromClass in session tests	Reedy	mediawiki/core	REL1_41	+42 -55
tests: Use TestingAccessWrapper::newFromClass in session tests	Umherirrender	mediawiki/core	master	+42 -55

Customize query in gerrit

Related Objects

Mentioned Here: T352060: Wikimedia::TestingAccessWrapper raises a deprecation warning in PHP 8.3

Event Timeline

Umherirrender created this task.Dec 6 2023, 7:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2023, 7:47 PM

Umherirrender claimed this task.Dec 6 2023, 7:47 PM

Change 980933 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Use TestingAccessWrapper::newFromClass in session tests

https://gerrit.wikimedia.org/r/980933

gerritbot added a project: Patch-For-Review.Dec 6 2023, 8:01 PM

Umherirrender updated the task description. (Show Details)Dec 6 2023, 8:19 PM

Umherirrender edited projects, added: MediaWiki-Core-AuthManager; removed: MediaWiki-Core-Tests.

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptDec 6 2023, 8:19 PM

Change 980933 merged by jenkins-bot:

[mediawiki/core@master] tests: Use TestingAccessWrapper::newFromClass in session tests

https://gerrit.wikimedia.org/r/980933

Umherirrender closed this task as Resolved.Dec 6 2023, 9:36 PM

Umherirrender removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 6 2023, 11:00 PM

Change #1017403 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/core@REL1_41] tests: Use TestingAccessWrapper::newFromClass in session tests

https://gerrit.wikimedia.org/r/1017403

gerritbot added a project: Patch-For-Review.Apr 5 2024, 10:30 PM

Change #1017403 merged by jenkins-bot:

[mediawiki/core@REL1_41] tests: Use TestingAccessWrapper::newFromClass in session tests

https://gerrit.wikimedia.org/r/1017403

Change #1017434 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/core@REL1_40] tests: Use TestingAccessWrapper::newFromClass in session tests

https://gerrit.wikimedia.org/r/1017434

ReleaseTaggerBot added a project: MW-1.41-notes.Apr 6 2024, 12:00 AM

Change #1017440 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/core@REL1_39] tests: Use TestingAccessWrapper::newFromClass in session tests

https://gerrit.wikimedia.org/r/1017440

Change #1017440 merged by jenkins-bot: