Page MenuHomePhabricator

On wikitech, DiscussionTools doesn't render reply links with "?useparsoid=1" when logged out
Closed, ResolvedPublic

Description

Take a look at this: https://wikitech.wikimedia.org/wiki/Talk%3AData%20Engineering?useparsoid=1 while logged in and logged out. When logged out, the reply links don't show.

In contrast, https://wikitech.wikimedia.org/wiki/Talk%3AData%20Engineering renders reply links for both logged in and logged out users. For logged out users, the reply links here open a popup informing the user that they cannot reply.

What is the right solution here? Should DiscussionTools hide reply links for logged out users (if they don't cannot edit the page as logged out users)? Or, should we properly implement the 'isPreview' functionality when "?useparsoid=1" so that reply links are show always even with Parsoid?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reiterating a point I made on slack for public consideration: there's currently a clash of philosophies between the edit links and the reply buttons. On a page you can't edit (for whatever reason) the "edit" tab becomes "view source" and the edit section links are entirely removed, but the reply buttons remain and tell you why you can't edit if you attempt to. Ultimately it might be a good idea to bring these two ways of editing a page into alignment on this topic.

I'm sort of ideologically inclined as part of the wiki movement towards keeping edit links visible everywhere as a way to reinforce that the pages could be editable if you log in / become autoconfirmed / whatever. I'm not actually sure which is better from a product-usability perspective, though...

I'm sort of ideologically inclined as part of the wiki movement towards keeping edit links visible everywhere as a way to reinforce that the pages could be editable if you log in / become autoconfirmed / whatever.

I second that, for wikis where the regular editing process is open. For wikis where the regular editing process is closed (like wikitech which requires to login), removing the reply link can be justified.

ssastry triaged this task as Medium priority.Feb 15 2024, 2:45 AM
ssastry moved this task from In Progress to To Deploy on the Content-Transform-Team-WIP board.
ssastry claimed this task.