Cargo adds the following JS config variables to pages where they're not used (e.g. Special:Preferences, but it it looks like it's actually just every page):
Yes - it looks like those variables should not be included for any special pages (other than Cargo's own Special:CargoQuery and Special:CargoExport, both of which might use them), or if the "action" (i.e., Context::getActionName()) is anything other than "view".
@Yaron_Koren I want to participate in gsoc24 under your mentorship, so may I know what all you expect from me ?
Like how much time or how many issues I should fix before gsoc24 ?
I discovered that three of these six global JS variables are no longer actually getting used anywhere, so I removed them in fdbbb72c559c. That still leaves three variables, though, that should be subject to this new logic.
yes @Yaron_Koren As I can clearly see that you have removed the following variables -
And the variables to be removed are
wgCargoDefaultQueryLimit
wgCargoMapClusteringMinimum
wgCargoMonthNamesShort
Change 1008918 had a related patch set uploaded (by Jatinder1901; author: Jatinder1901):
[mediawiki/extensions/Cargo@master] Fix:Removed-Unused-Variables
Change 1009563 had a related patch set uploaded (by Obamwonyi; author: Obamwonyi):
[mediawiki/extensions/Cargo@master] fixed unnecessary addition of JS config vars to all pages
Change 1008918 abandoned by Yaron Koren:
[mediawiki/extensions/Cargo@master] Fix:Removed-Unused-Variables
Reason:
Incorrect patch
Change #1009563 merged by jenkins-bot:
[mediawiki/extensions/Cargo@master] fixed unnecessary addition of JS config vars to all pages