Page MenuHomePhabricator

Transcluding the form from Special:Contributions causes skin preference to be overridden
Closed, ResolvedPublicBUG REPORT


Steps to replicate the issue (include links if applicable):

POC url:

  • Set your skin preference to something other than the default.
  • Transclude {{Special:Contributions|target=foo/../}} on to a page
  • preview the page or save and immediately view (It has to be rendered within the request for bug to appear. Bug does not appear when serving page from parser cache)

What happens?:

  • User's skin preference is overriden to default skin

What should have happened instead?:

  • Skin should not be overriden

Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):

I suspect HTMLForm sets something to a global somewhere which then escapes the global isolation that Parser::braceSubstitution tries to set up.

Event Timeline

Change 982170 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] specials: Do not show form when transclude Special:Contributions

Change 982170 merged by jenkins-bot:

[mediawiki/core@master] specials: Do not show form when transclude Special:Contributions

matmarex assigned this task to Umherirrender.