| taavi | |
| Dec 11 2023, 6:17 PM |
| F41597664: Screenshot 2023-12-13 at 03.20.57.png | |
| Dec 13 2023, 8:47 AM | |
| File Not Attached |
| F41594676: image.png | |
| Dec 11 2023, 6:17 PM |
For example, PS1 of this CentralAuth patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/982144/ is showing PCC under "error" in the checks tab:
E.g.
It seems any patch with a check experimental trigger, is attempting to render a link to a Puppet Compiler result.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| wm-pcc: only act on Puppet repositories | operations/software/gerrit | deploy/wmf/stable-3.5 | +16 -1 |
Change 983377 had a related patch set uploaded (by Hashar; author: Hashar):
[operations/software/gerrit@deploy/wmf/stable-3.5] wm-pcc: only act on Puppet repositories
Change 983377 merged by jenkins-bot:
[operations/software/gerrit@deploy/wmf/stable-3.5] wm-pcc: only act on Puppet repositories
Mentioned in SAL (#wikimedia-operations) [2023-12-15T11:28:16Z] <hashar@deploy2002> Started deploy [gerrit/gerrit@304c63a]: wm-pcc: only act on Puppet repositories - T353181
Mentioned in SAL (#wikimedia-operations) [2023-12-15T11:28:24Z] <hashar@deploy2002> Finished deploy [gerrit/gerrit@304c63a]: wm-pcc: only act on Puppet repositories - T353181 (duration: 00m 08s)
The plugin is a little too broad in processing Jenkins build URL and thus end up generating PCC results for builds that lack the required information (since they are not puppet compiles that makes sense). The fix I have deployed is to only have the plugin act on repositories for which we run the compiler: operations/puppet and labs/private.
That fixed it.