Remove WikimediaEvents diff instrumentation
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 13 2023, 7:21 PM

Description

Background

Last year we added instrumented some logging on diffs (T326212). After pivoting to different projects we didn't end up needing this.

If this is not being used we should decommission the instrumentation again, since it's adding some minor technical maintenance workload for us (that being the mobile diff thanks instrumentation is broken).

AC/TODO

Remove all code that logs specialDiff.click.* events
Remove the mediawiki.special_diff_interactions stream configuration
Remove the mediawiki.special_diff_interactions $wgEventLoggingStreamNames entry
Remove the event sanitisation allowlist entry, if necessary
Request the deletion of any previously sanitised data, if necessary

Notes

It appears that the data was never sanitised so I've marked the relevant TODO entries as Done™
Re.

Request the deletion of the mediawiki_special_diff_interactions table

Per T353366#9445335, the data are currently being analysed. Request the deletion of the table when the analysis is Done™.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
ext-EventLogging,ext-EventStreamConfig: Remove mediawiki.special_diff_interactions stream	operations/mediawiki-config	master	+0 -28
Remove diff instrumentation	mediawiki/extensions/WikimediaEvents	master	+0 -186
Remove the Special:Diff interactions instrument	mediawiki/extensions/WikimediaEvents	master	+0 -186

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T408059 [GOAL] Tidy up EventLogging
Resolved		phuedx	T352969 Deprecate and remove MetricsClient#dispatch()
Resolved	BUG REPORT	phuedx	T353366 Remove WikimediaEvents diff instrumentation

Event Timeline

Jdlrobson created this task.Dec 13 2023, 7:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2023, 7:21 PM

Jdlrobson renamed this task from Remove WikimediaEvents MobileDiff instrumentation to Remove WikimediaEvents diff instrumentation.Dec 13 2023, 7:22 PM

Change 980910 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaEvents@master] Remove diff instrumentation

https://gerrit.wikimedia.org/r/980910

gerritbot added a project: Patch-For-Review.Dec 13 2023, 7:24 PM

Jdlrobson updated the task description. (Show Details)Dec 13 2023, 7:24 PM

TheresNoTime subscribed.Dec 14 2023, 11:55 AM

Samwalton9-WMF mentioned this in T353438: What actions do users take on Special:Diff and Special:MobileDiff?.Dec 14 2023, 12:00 PM

Jdlrobson mentioned this in T352869: Migrate SpecialDiff instrument to use submitClick().Dec 14 2023, 9:23 PM

@Samwalton9-WMF: Could you confirm that you're happy with the instrument to be removed? IIRC your team created it.

In T353366#9429706, @phuedx wrote:

@Samwalton9-WMF: Could you confirm that you're happy with the instrument to be removed? IIRC your team created it.

Confirming! We're going to do some quick analysis on this data (T353438) but the instrumentation can be removed in the meantime.

phuedx updated the task description. (Show Details)Jan 9 2024, 5:00 PM

phuedx added projects: Metrics Platform, Test Kitchen (Data Products Sprint 07).

phuedx added a parent task: T352969: Deprecate and remove MetricsClient#dispatch().

phuedx updated the task description. (Show Details)Jan 9 2024, 5:05 PM

phuedx set the point value for this task to 3.Jan 16 2024, 10:46 AM

phuedx moved this task from Backlog to Instruments on the Metrics Platform board.Jan 16 2024, 11:48 AM

phuedx updated the task description. (Show Details)Jan 17 2024, 9:54 AM

Change 991606 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] ext-EventLogging,ext-EventStreamConfig: Remove mediawiki.special_diff_interactions stream

https://gerrit.wikimedia.org/r/991606

Change 991608 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/WikimediaEvents@master] Remove the Special:Diff interactions instrument

https://gerrit.wikimedia.org/r/991608

phuedx claimed this task.Jan 18 2024, 2:57 PM

phuedx moved this task from Sprint Backlog to Code Review / Tech Input on the Test Kitchen (Data Products Sprint 07) board.

Change 991608 abandoned by Phuedx:

[mediawiki/extensions/WikimediaEvents@master] Remove the Special:Diff interactions instrument

Reason:

See Ifb46fe39ec32d6a382263762515ed6b075f89985

https://gerrit.wikimedia.org/r/991608

phuedx moved this task from Code Review / Tech Input to To Deploy on the Test Kitchen (Data Products Sprint 07) board.Jan 23 2024, 9:44 AM

Change 980910 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Remove diff instrumentation

https://gerrit.wikimedia.org/r/980910

phuedx updated the task description. (Show Details)Jan 23 2024, 10:18 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 23 2024, 11:00 AM

Change 991606 merged by jenkins-bot:

[operations/mediawiki-config@master] ext-EventLogging,ext-EventStreamConfig: Remove mediawiki.special_diff_interactions stream

https://gerrit.wikimedia.org/r/991606

Mentioned in SAL (#wikimedia-operations) [2024-01-23T14:06:47Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Started scap: Backport for [[gerrit:991606|ext-EventLogging,ext-EventStreamConfig: Remove mediawiki.special_diff_interactions stream (T353366)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-23T14:08:41Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 lucaswerkmeister-wmde and phuedx: Backport for [[gerrit:991606|ext-EventLogging,ext-EventStreamConfig: Remove mediawiki.special_diff_interactions stream (T353366)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-23T14:18:33Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Finished scap: Backport for [[gerrit:991606|ext-EventLogging,ext-EventStreamConfig: Remove mediawiki.special_diff_interactions stream (T353366)]] (duration: 11m 49s)