Page MenuHomePhabricator
Create Task
Maniphest T353465

Page scrolls to top when opening VE mobile
Closed, ResolvedPublic
Actions

Description

The current heading should be positioned at the top of the page to ensure a smooth transition to editing. This was working until very recently.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Match section param inside query stringEsandersmediawiki/extensions/MobileFrontendmaster+8 -4
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Dec 14 2023, 4:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2023, 4:23 PM
Esanders added subscribers: • matmarex, cscott.Dec 14 2023, 5:22 PM

The data-section attributes appears to no longer be in the DOM.

• matmarex added a subscriber: Jdlrobson.Dec 14 2023, 5:35 PM

They were removed in rSMIN0c8caebfc6e6: Generate section edit links via SkinMustache…

Esanders triaged this task as High priority.Dec 14 2023, 6:04 PM

@Jdlrobson is there a reason data-section was removed?

gerritbot added a comment.Dec 14 2023, 6:18 PM

Change 983251 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Match section param inside query string

https://gerrit.wikimedia.org/r/983251

gerritbot added a project: Patch-For-Review.Dec 14 2023, 6:18 PM
Esanders moved this task from To Triage to Triaged on the VisualEditor board.Dec 14 2023, 6:21 PM
Jdlrobson added a comment.Dec 14 2023, 6:46 PM

@Esanders seems like a mistake. Should we add the data attribute back in core or do you prefer relying on the query string as in your patch?

• matmarex added a comment.Dec 15 2023, 7:07 PM

I guess this works well enough. We have T300467 about making the section number more easily accessible.

gerritbot added a comment.Dec 15 2023, 7:49 PM

Change 983251 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Match section param inside query string

https://gerrit.wikimedia.org/r/983251

• matmarex added a project: Editing-team (Kanban Board).Dec 15 2023, 7:59 PM
• matmarex moved this task from Inbox to QA on the Editing-team (Kanban Board) board.
• matmarex edited projects, added: Editing QA; removed: Patch-For-Review.
Ryasmeen edited projects, added: Verified; removed: Editing QA.Dec 18 2023, 5:08 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Esanders closed this task as Resolved.Dec 20 2023, 3:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits