Thanks: Error: Call to a member function getId() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	brennen
	Dec 14 2023, 4:28 PM

Description

Error

service.version: 1.42.0-wmf.9
trace.id: 54a8700b-08ce-4f41-a929-3de608a80adc
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   Error: Call to a member function getId() on null

error.stack_trace

from /srv/mediawiki/php-1.42.0-wmf.9/extensions/Thanks/includes/SpecialThanks.php(193)
#0 /srv/mediawiki/php-1.42.0-wmf.9/includes/specialpage/FormSpecialPage.php(236): MediaWiki\Extension\Thanks\SpecialThanks->onSuccess()
#1 /srv/mediawiki/php-1.42.0-wmf.9/includes/specialpage/SpecialPage.php(727): MediaWiki\SpecialPage\FormSpecialPage->execute(string)
#2 /srv/mediawiki/php-1.42.0-wmf.9/includes/specialpage/SpecialPageFactory.php(1652): MediaWiki\SpecialPage\SpecialPage->run(string)
#3 /srv/mediawiki/php-1.42.0-wmf.9/includes/MediaWiki.php(359): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#4 /srv/mediawiki/php-1.42.0-wmf.9/includes/MediaWiki.php(962): MediaWiki->performRequest()
#5 /srv/mediawiki/php-1.42.0-wmf.9/includes/MediaWiki.php(615): MediaWiki->main()
#6 /srv/mediawiki/php-1.42.0-wmf.9/index.php(50): MediaWiki->run()
#7 /srv/mediawiki/php-1.42.0-wmf.9/index.php(46): wfIndexMain()
#8 /srv/mediawiki/w/index.php(3): require(string)
#9 {main}

Impact

Notes

Error seems to be here:

https://gerrit.wikimedia.org/g/mediawiki/extensions/Thanks/+/31bcd7289850050d6afe8c0a5639f672c9d648d6/includes/SpecialThanks.php#193

One of these in 1.42.0-wmf.9 (T350085), though I'm guessing it's likely older.

Details

Request URL: https://it.wikipedia.org/wiki/Speciale:Ringrazia/136888952

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Avoid fatal when thanks ip via Special:Thanks	mediawiki/extensions/Thanks	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned Here: T350085: 1.42.0-wmf.9 deployment blockers

Event Timeline

brennen created this task.Dec 14 2023, 4:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2023, 4:28 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Dec 14 2023, 4:28 PM

brennen moved this task from Untriaged to Dec 2023 on the Wikimedia-production-error board.Dec 14 2023, 4:30 PM

The oldid from the request url has an ip as username. It is not possible to thanks ips.

Maybe the non-js mode (via Special:Thanks) does not handle this situation correct.
Is a low used endpoint, as most users has js enabled, but needs fixing.

KStoller-WMF moved this task from Inbox to Triaged on the Growth-Team board.Jan 23 2024, 9:50 AM

Change 992535 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Thanks@master] Avoid fatal when thanks ip via Special:Thanks

https://gerrit.wikimedia.org/r/992535

gerritbot added a project: Patch-For-Review.Jan 23 2024, 9:28 PM

Umherirrender claimed this task.Jan 23 2024, 9:29 PM

Change 992535 merged by jenkins-bot: