Page MenuHomePhabricator
Create Task
Maniphest T353512

CentralAuthApiSessionProviderTest::testUserScriptsDisabled failing in CI
Closed, ResolvedPublic
Actions

Description

This is blocking Wikibase CI, possibly other extensions too.

11:18:25 1) CentralAuthApiSessionProviderTest::testUserScriptsDisabled
11:18:25 MediaWiki\Session\Session::isPersistent() was not expected to be called.

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/142621/console

Details

SubjectRepoBranchLines +/-
tests: Mock Session::isPersistent to return truemediawiki/extensions/CentralAuthmaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Jakob_WMDE created this task.Dec 15 2023, 10:41 AM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptDec 15 2023, 10:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Umherirrender edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error.Dec 15 2023, 1:18 PM
Umherirrender subscribed.

The call to Session::isPersistent is new today from 9f1af3763bd57778847ffeac66af6100c5578275

gerritbot added a comment.Dec 15 2023, 1:24 PM

Change 983399 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralAuth@master] tests: Mock Session::isPersistent to return true

https://gerrit.wikimedia.org/r/983399

gerritbot added a project: Patch-For-Review.Dec 15 2023, 1:24 PM
gerritbot added a comment.Dec 15 2023, 1:38 PM

Change 983399 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] tests: Mock Session::isPersistent to return true

https://gerrit.wikimedia.org/r/983399

Umherirrender closed this task as Resolved.Dec 15 2023, 1:39 PM
Umherirrender claimed this task.
Umherirrender removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 15 2023, 2:00 PM
Dreamy_Jazz mentioned this in T365403: CentralAuthApiSessionProviderTest::testUserScriptsDisabled is failing in CI.May 20 2024, 10:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits