Page MenuHomePhabricator

Category defaultsort should be applied in CategoryLinkTable.php
Open, Needs TriagePublic

Description

The "defaultsort" is another 'applies only after its position on the page' property which violates T300979. It should be rewritten so that the ParserOutput keeps the '' (meaning "default sort key") and in CategoryLinksTable we change it from '' to the actual default sort key by looking in the page properties at that time.

That ensures that the default sort applies regardless of where it appears on the page, and avoids read-modify-write issues.

Related Objects

StatusSubtypeAssignedTask
OpenReleaseNone
OpenNone
OpenNone
OpenNone
OpenFeatureNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedcscott
Opencscott
Resolvedmatmarex
OpenNone
Opencscott
Opencscott
Resolvedcscott
OpenNone
ResolvedNone
OpenNone
OpenNone
Opencscott
Opencscott
Opencscott
OpenNone
OpenNone
ResolvedBUG REPORTJgiannelos

Event Timeline

Change 983434 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Compute category sort key when filling links table, not at parse time

https://gerrit.wikimedia.org/r/983434

Change #983434 merged by jenkins-bot:

[mediawiki/core@master] Substitute category default sort key when filling links table, not at parse time

https://gerrit.wikimedia.org/r/983434

Change #1020865 had a related patch set uploaded (by Arlolra; author: C. Scott Ananian):

[mediawiki/core@REL1_42] Substitute category default sort key when filling links table, not at parse time

https://gerrit.wikimedia.org/r/1020865

Change #1020865 merged by jenkins-bot:

[mediawiki/core@REL1_42] Substitute category default sort key when filling links table, not at parse time

https://gerrit.wikimedia.org/r/1020865