[LIB] Re-enable Phan CI checks for Wikibase libraries
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ArthurTaylor
	Dec 18 2023, 11:26 AM

Description

Some directories are excluded from Phan checks as a result of T289040: Migrate DataModel, DataModelServices, DataModelSerialization, WBInternalSerialization to Wikibase.git. .phan/config.php (link) includes the folders for the libraries in exclude_analysis_directory_list.

Enabling Phan checks results in a build failure. The task would be to resolve the Phan warnings and re-enable checks for these libraries.

Acceptance criteria

Wikibase monorepo libraries are not in the exclude_analysis_directory_list at .phan/config.php (link)

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Re-enable Phan and fix warnings for `internal-serialization`	mediawiki/extensions/Wikibase	master	+4 -6
Re-enable Phan and fix warnings for `data-model-serialization'	mediawiki/extensions/Wikibase	master	+3 -4
Re-enable Phan and fix warnings for `data-model-services'	mediawiki/extensions/Wikibase	master	+57 -33
Re-enable Phan and fix warnings / errors for `data-model/src'	mediawiki/extensions/Wikibase	master	+56 -35

Customize query in gerrit

Related Objects

Mentioned Here: T289040: Migrate DataModel, DataModelServices, DataModelSerialization, WBInternalSerialization to Wikibase.git

Event Timeline

ArthurTaylor created this task.Dec 18 2023, 11:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2023, 11:26 AM

We can probably go package by package; some have more warnings than others:

36 wikibase/data-model
 4 wikibase/data-model-serialization
20 wikibase/data-model-services
 5 wikibase/internal-serialization

Michael subscribed.Dec 18 2023, 11:29 AM

karapayneWMDE moved this task from Incoming to Unified QT Backlog on the [Archived]Wikidata Dev Team board.Dec 19 2023, 3:04 PM

karapayneWMDE moved this task from Unified QT Backlog to [DOT] Tech Backlog on the [Archived]Wikidata Dev Team board.

Lucas_Werkmeister_WMDE renamed this task from Re-enable Phan CI checks for Wikibase libraries to [LIB] [TECH] Re-enable Phan CI checks for Wikibase libraries.Feb 9 2024, 3:21 PM

Lucas_Werkmeister_WMDE moved this task from Incoming to [DOT] By Project on the wmde-wikidata-tech board.

removed from dev board until it goes through the prioritization pipeline

ItamarWMDE moved this task from [DOT] By Project to Wikidata Omega Triage on the wmde-wikidata-tech board.Dec 4 2024, 11:41 AM

ItamarWMDE edited projects, added wmde-wikidata-tech (Wikidata Omega Triage); removed wmde-wikidata-tech.

ItamarWMDE moved this task from Incoming to Lib on the wmde-wikidata-tech (Wikidata Omega Triage) board.Dec 4 2024, 2:07 PM

ItamarWMDE moved this task from Lib to Infrastructure on the wmde-wikidata-tech (Wikidata Omega Triage) board.Dec 4 2024, 3:20 PM

ItamarWMDE moved this task from Infrastructure to Checks Completeness on the wmde-wikidata-tech (Wikidata Omega Triage) board.Dec 6 2024, 10:41 AM

Prio Notes:

Impact Area	Affected
production / end users	no
monitoring	no
development efforts	yes
onboarding efforts	no
additional stakeholders	no

ItamarWMDE triaged this task as Low priority.Dec 6 2024, 11:08 AM

ItamarWMDE moved this task from Checks Completeness to Prioritized - Moving a task here moves the ticket to Wikidata Dev and removes it from this board on the wmde-wikidata-tech (Wikidata Omega Triage) board.Dec 6 2024, 12:00 PM

ItamarWMDE edited projects, added [Archived]Wikidata Dev Team; removed wmde-wikidata-tech (Wikidata Omega Triage).

ItamarWMDE renamed this task from [SW] [LIB] [TECH] Re-enable Phan CI checks for Wikibase libraries to [LIB] Re-enable Phan CI checks for Wikibase libraries.Dec 12 2024, 11:50 AM

ItamarWMDE updated the task description. (Show Details)

ItamarWMDE moved this task from [DOT] Tech Backlog to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.

ArthurTaylor claimed this task.Feb 18 2025, 1:36 PM

ArthurTaylor moved this task from SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) to Wikidata.org Slice on the [Archived]Wikidata Dev Team board.

ArthurTaylor edited projects, added [Archived]Wikidata Dev Team (Wikidata.org Slice); removed [Archived]Wikidata Dev Team.

ArthurTaylor moved this task from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Change #1122531 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Re-enable Phan and fix warnings / errors for `data-model/src'

https://gerrit.wikimedia.org/r/1122531

gerritbot added a project: Patch-For-Review.Feb 25 2025, 10:03 AM

Change #1122541 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Re-enable Phan and fix warnings for `data-model-serialization'

https://gerrit.wikimedia.org/r/1122541

Change #1122549 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Re-enable Phan and fix warnings for `data-model-services'

https://gerrit.wikimedia.org/r/1122549

Change #1122551 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Re-enable Phan and fix warnings for `internal-serialization`

https://gerrit.wikimedia.org/r/1122551

ArthurTaylor removed ArthurTaylor as the assignee of this task.Feb 25 2025, 1:38 PM

ArthurTaylor moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

AudreyPenven_WMDE claimed this task.Mar 3 2025, 2:49 PM

AudreyPenven_WMDE moved this task from Ready for Peer Review to In Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Change #1122531 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Re-enable Phan and fix warnings / errors for `data-model/src'

https://gerrit.wikimedia.org/r/1122531

Change #1122541 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Re-enable Phan and fix warnings for `data-model-serialization'

https://gerrit.wikimedia.org/r/1122541

Change #1122549 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Re-enable Phan and fix warnings for `data-model-services'

https://gerrit.wikimedia.org/r/1122549

Change #1122551 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Re-enable Phan and fix warnings for `internal-serialization`

https://gerrit.wikimedia.org/r/1122551

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.19; 2025-03-04).Mar 3 2025, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2025, 4:31 PM

AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.Mar 3 2025, 4:45 PM

AudreyPenven_WMDE moved this task from In Peer Review to Ready for Tech Verification on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

AudreyPenven_WMDE subscribed.

karapayneWMDE assigned this task to ArthurTaylor.Mar 7 2025, 3:12 PM

karapayneWMDE moved this task from Ready for Tech Verification to In Tech Verification on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

karapayneWMDE moved this task from In Tech Verification to Done on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

karapayneWMDE closed this task as Resolved.Mar 7 2025, 3:14 PM

[LIB] Re-enable Phan CI checks for Wikibase librariesClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[LIB] Re-enable Phan CI checks for Wikibase libraries
Closed, ResolvedPublic
Actions