REST: Trying to load the content "magic" image description pages leads to redirect loop
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	daniel
	Dec 19 2023, 6:47 AM

Description

Steps to replicate the issue (include links if applicable):

try to load https://de.wikipedia.org/w/rest.php/v1/page/Datei%3AJPG_Test.jpg/html

What happens?:

Receive a 307 pointing to the same URL again

What should have happened instead?:

Receive a 301 pointing to the appropriate URL on commons.wikimedia.org https://commons.wikimedia.org/w/rest.php/v1/page/File%3ATest.jpg/html
OR: return a 404, because the page does not exist locally.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
WikiFilePage: Fix handling of file redirects	mediawiki/core	master	+123 -12
REST: Add tests for handling file description pages	mediawiki/core	master	+86 -0
Intercept self-redirects triggered by virtual file description pages	mediawiki/core	master	+17 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Stalled		None	T324931 Clean up open RESTBase related tickets
Open		None	T262315 <CORE TECHNOLOGY> API Migration & RESTBase Sunset
Resolved		Jgiannelos	T344944 Move Parsoid endpoints out of RESTBase
In Progress		None	T374135 Migrate RESTbase page content endpoints
Open		MSantos	T334238 Create deprecation plan for public parsoid endpoints
Resolved		MSantos	T335512 Transition Enterprise MediaWiki from RESTBase to core page HTML endpoints
Resolved	BUG REPORT	daniel	T353688 REST: Trying to load the content "magic" image description pages leads to redirect loop

Event Timeline

daniel created this task.Dec 19 2023, 6:47 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2023, 6:47 AM

daniel triaged this task as High priority.Dec 19 2023, 6:49 AM

daniel added a project: RESTBase Sunsetting.Dec 19 2023, 7:04 AM

daniel added subscribers: prabhat, ssastry, MSantos.

Maintenance_bot added a project: Commons.Dec 19 2023, 7:30 AM

daniel updated the task description. (Show Details)Dec 19 2023, 8:16 AM

Change 984098 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Intercept self-redirects triggered by virtual file description pages

https://gerrit.wikimedia.org/r/984098

gerritbot added a project: Patch-For-Review.Dec 19 2023, 8:20 AM

The proposed patch will trigger a 404 when trying to load the HTML for a "magic" file description page.
Making it redirect to the appropriate REST URL on for foreign repo isn't possible right now, since we have no way to (reliably) know the REST path of the remote repo.

ssastry renamed this task from REST: Trying to load the content "magic" image scription pages leads to redirect loop to REST: Trying to load the content "magic" image description pages leads to redirect loop.Dec 19 2023, 3:44 PM

prabhat mentioned this in T335512: Transition Enterprise MediaWiki from RESTBase to core page HTML endpoints.Dec 19 2023, 3:46 PM

daniel added a parent task: T335512: Transition Enterprise MediaWiki from RESTBase to core page HTML endpoints.Dec 19 2023, 4:05 PM

Change 984098 merged by jenkins-bot:

[mediawiki/core@master] Intercept self-redirects triggered by virtual file description pages

https://gerrit.wikimedia.org/r/984098

Maintenance_bot removed a project: Patch-For-Review.Dec 19 2023, 9:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Dec 19 2023, 10:00 PM

Change 985328 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] REST: Add tests for handling file description pages

https://gerrit.wikimedia.org/r/985328

gerritbot added a project: Patch-For-Review.Dec 22 2023, 6:07 PM

Change 985330 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):