MediaModerationPhotoDNAServiceProvider provides false to FileBackend::getFileContents causing a PHP Notice
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Error details

Logstash single document

message

[{reqId}] {exception_url}   PHP Notice: Undefined offset: 0

trace

from /srv/mediawiki/php-1.42.0-wmf.10/includes/libs/filebackend/FileBackend.php(1020)
#0 /srv/mediawiki/php-1.42.0-wmf.10/includes/libs/filebackend/FileBackend.php(1020): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.42.0-wmf.10/extensions/MediaModeration/src/Services/MediaModerationPhotoDNAServiceProvider.php(210): FileBackend->getFileContents(array)
#2 /srv/mediawiki/php-1.42.0-wmf.10/extensions/MediaModeration/src/Services/MediaModerationPhotoDNAServiceProvider.php(125): MediaWiki\Extension\MediaModeration\Services\MediaModerationPhotoDNAServiceProvider->getThumbnailContents(ThumbnailImage)
#3 /srv/mediawiki/php-1.42.0-wmf.10/extensions/MediaModeration/src/Services/MediaModerationPhotoDNAServiceProvider.php(76): MediaWiki\Extension\MediaModeration\Services\MediaModerationPhotoDNAServiceProvider->getRequest(LocalFile)
#4 /srv/mediawiki/php-1.42.0-wmf.10/extensions/MediaModeration/maintenance/scanFilesInScanTable.php(97): MediaWiki\Extension\MediaModeration\Services\MediaModerationPhotoDNAServiceProvider->check(LocalFile)
#5 /srv/mediawiki/php-1.42.0-wmf.10/maintenance/includes/MaintenanceRunner.php(703): MediaWiki\Extension\MediaModeration\Maintenance\ScanFilesInScanTable->execute()
#6 /srv/mediawiki/php-1.42.0-wmf.10/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run()
#7 /srv/mediawiki/multiversion/MWScript.php(158): require_once(string)
#8 {main}

Steps to replicate

Install the MediaModeration extension
Run the scanFilesInScanTable.php maintenance script provided by MediaModeration
Inspect the server logs

What happens: Several warnings appear about an undefined offest 0.
What should happen: These should be handled such that no php notice is created.

Notes

Seems to be because a value of false is being provided to FileBackend::getFileContents as the value of the src key. This gets presumably converted to a 0 by PHP typecasting to a string.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Check for false from ThumbnailImage::getStoragePath	mediawiki/extensions/MediaModeration	wmf/1.42.0-wmf.10	+68 -1
	Check for false from ThumbnailImage::getStoragePath	mediawiki/extensions/MediaModeration	master	+68 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• Dreamy_Jazz	T351200 [EPIC] Start automated scanning
Duplicate		None	T351400 Run the maintenance script scanning images in mediamoderation_scan on WMF wikis
Resolved	BUG REPORT	• Dreamy_Jazz	T353758 MediaModerationPhotoDNAServiceProvider provides false to FileBackend::getFileContents causing a PHP Notice
Resolved		• Dreamy_Jazz	T351399 Create a maintenance script to automatically scan files listed in mediamoderation_scan
Resolved		kostajh	T351401 Create service(s) to send an image to PhotoDNA for a scan
Resolved		• Dreamy_Jazz	T351407 Create a service that sends an email when a file matches
Resolved		• Dreamy_Jazz	T351417 Create a service that creates LocalFile and ArchivedFile objects for files that have a given SHA-1
Resolved		• Dreamy_Jazz	T351416 [S] Explore how many rows in the file tables have duplicated SHA-1 values on WMF wikis
Resolved		• Dreamy_Jazz	T351409 Expand the database lookup service to get rows from the mediamoderation_scan table
Resolved		• Dreamy_Jazz	T351112 [S] Create an initial service to lookup scan rows from the database
Resolved		• Dreamy_Jazz	T350321 [M] Create database table to store status of scans

Event Timeline

• Dreamy_Jazz created this task.Dec 19 2023, 10:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2023, 10:40 PM

This had 3,000 entries in Logstash when the script was run on testwiki. This suggests that it blocks running a scan on commonswiki.

Change 984293 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Check for false from ThumbnailImage::getStoragePath

https://gerrit.wikimedia.org/r/984293

gerritbot added a project: Patch-For-Review.Dec 19 2023, 10:47 PM

• Dreamy_Jazz added a subtask: T351399: Create a maintenance script to automatically scan files listed in mediamoderation_scan.Dec 19 2023, 10:48 PM

• Dreamy_Jazz added a parent task: T351400: Run the maintenance script scanning images in mediamoderation_scan on WMF wikis.

• Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)) board.

Change 984324 had a related patch set uploaded (by Kosta Harlan; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@wmf/1.42.0-wmf.10] Check for false from ThumbnailImage::getStoragePath

https://gerrit.wikimedia.org/r/984324

Change 984293 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Check for false from ThumbnailImage::getStoragePath

https://gerrit.wikimedia.org/r/984293

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Dec 20 2023, 9:01 AM

Change 984324 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@wmf/1.42.0-wmf.10] Check for false from ThumbnailImage::getStoragePath

https://gerrit.wikimedia.org/r/984324

Mentioned in SAL (#wikimedia-operations) [2023-12-20T14:21:00Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:984324|Check for false from ThumbnailImage::getStoragePath (T353758)]]

Mentioned in SAL (#wikimedia-operations) [2023-12-20T14:22:18Z] <lucaswerkmeister-wmde@deploy2002> kharlan and lucaswerkmeister-wmde: Backport for [[gerrit:984324|Check for false from ThumbnailImage::getStoragePath (T353758)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Dec 20 2023, 2:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-20T14:30:39Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:984324|Check for false from ThumbnailImage::getStoragePath (T353758)]] (duration: 09m 38s)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.10; 2023-12-19); removed MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Dec 20 2023, 3:00 PM

• Dreamy_Jazz set the point value for this task to 1.Dec 21 2023, 11:43 PM

• Dreamy_Jazz changed the point value for this task from 1 to 2.

This will be difficult to effectively QA and cannot be done on betawikis. I propose that QA be skipped for this ticket and brought into the QA of T351399 (as this ticket adds a fix for the code added in that ticket).

I concur with Dreamy_Jazz's comment regarding QA and therefore am pushing this ticket to Done.

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)) board.Jan 2 2024, 5:30 PM

• Dreamy_Jazz closed this task as Resolved.Jan 3 2024, 3:35 PM

• Dreamy_Jazz closed subtask T351399: Create a maintenance script to automatically scan files listed in mediamoderation_scan as Resolved.Jan 8 2024, 4:14 PM

MediaModerationPhotoDNAServiceProvider provides false to FileBackend::getFileContents causing a PHP NoticeClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions