ParserOutput.php: Cannot declare class ParserOutput, because the name is already in use
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.42.0-wmf.9
reqId: 9bfec9a0-8991-499c-b2a1-2a1b7bfab558
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Fatal Error from line 51 of /srv/mediawiki/php-1.42.0-wmf.9/includes/parser/ParserOutput.php: Cannot declare class ParserOutput, because the name is already in use

exception.trace

from /srv/mediawiki/php-1.42.0-wmf.9/includes/parser/ParserOutput.php(51)
#0 [internal function]: MWExceptionHandler::handleFatalError()
#1 {main}

Impact

Reports of wikidata.org and en.wikisource.org being down.
High logged error rate.

Notes

Happened when I rolled 1.42.0-wmf.10 to group1. Rolling back did not fix the problem.

Details

Request URL: https://foundation.wikimedia.org/wiki/Special:MyLanguage/Policy:Privacy_policy

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Protect against ParserOutput/CacheTime re-namespacing	mediawiki/core	REL1_39	+9 -1
Protect against ParserOutput re-namespacing	mediawiki/core	master	+4 -1
Be more aggressive in protecting against unserialization issues	mediawiki/core	master	+7 -0
Protect against ParserOutput re-namespacing	mediawiki/core	wmf/1.42.0-wmf.10	+4 -1
Protect against ParserOutput re-namespacing	mediawiki/core	wmf/1.42.0-wmf.9	+4 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		daniel	T325567 Document how to safely make changes to ParserOutput serialization
Resolved		cscott	T353883 JsonCodec should be robust against class aliases
Resolved	Release	dancy	T350086 1.42.0-wmf.10 deployment blockers
Resolved	PRODUCTION ERROR	cscott	T353835 PHP Fatal Error from line 51 of /srv/mediawiki/php-1.42.0-wmf.9/includes/parser/ParserOutput.php: Cannot declare class ParserOutput, because the name is already in use

Event Timeline

dancy created this task.Dec 20 2023, 7:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2023, 7:22 PM

dancy added a parent task: T350086: 1.42.0-wmf.10 deployment blockers.Dec 20 2023, 7:22 PM

Xover subscribed.Dec 20 2023, 7:24 PM

T353458: Make core classes follow PSR-4 / rMW9bfb75ff90d8: Namespace ParserOutput

Legoktm triaged this task as Unbreak Now! priority.Dec 20 2023, 7:27 PM

Legoktm added a project: Wikimedia-Incident.

dancy mentioned this in T350086: 1.42.0-wmf.10 deployment blockers.Dec 20 2023, 7:27 PM

dancy updated the task description. (Show Details)

kostajh added a subscriber: Jdlrobson.Dec 20 2023, 7:32 PM

kostajh subscribed.

DannyS712 subscribed.Dec 20 2023, 7:47 PM

Change 984636 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Be more aggressive in protecting against unserialization issues

https://gerrit.wikimedia.org/r/984636

Change 984637 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Protect against ParserOutput renamespacing.

https://gerrit.wikimedia.org/r/984637

Nikerabbit added a project: affects-translatewiki.net.Dec 20 2023, 8:05 PM

There are also many "Cannot declare class SiteList, because the name is already in use in SiteList.php" errors, do we want to track that in this task as well? Caused by rMW74287cf721b9: Namespace Site and SiteList

That's a caching pollution issue, it should go away in itself :/

Change 984492 had a related patch set uploaded (by Ladsgroup; author: C. Scott Ananian):

[mediawiki/core@wmf/1.42.0-wmf.9] Protect against ParserOutput re-namespacing

https://gerrit.wikimedia.org/r/984492

In T353835#9419833, @Ladsgroup wrote:

That's a caching pollution issue, it should go away in itself :/

I was meaning about Site and SiteList.

matmarex added a project: MediaWiki-General.Dec 20 2023, 8:16 PM

matmarex subscribed.

In T353835#9419835, @Ladsgroup wrote:

In T353835#9419833, @Ladsgroup wrote:

That's a caching pollution issue, it should go away in itself :/

I was meaning about Site and SiteList.

Confirming that the SiteList errors have stopped.

Change 984493 had a related patch set uploaded (by Ladsgroup; author: C. Scott Ananian):

[mediawiki/core@wmf/1.42.0-wmf.10] Protect against ParserOutput re-namespacing

https://gerrit.wikimedia.org/r/984493

taavi merged a task: T353837: Wikipedia page blocked by Wikimedia error.Dec 20 2023, 8:26 PM

taavi added a subscriber: Enter_content015236920.

@taavi, what should I do to resolve the error? Or should I simply wait for a solution from you? Thanks.

Change 984492 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.9] Protect against ParserOutput re-namespacing

https://gerrit.wikimedia.org/r/984492

Mentioned in SAL (#wikimedia-operations) [2023-12-20T20:40:39Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:984492|Protect against ParserOutput re-namespacing (T353835)]]

Mentioned in SAL (#wikimedia-operations) [2023-12-20T20:42:11Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:984492|Protect against ParserOutput re-namespacing (T353835)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-12-20T20:48:58Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:984492|Protect against ParserOutput re-namespacing (T353835)]] (duration: 08m 19s)

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 20 2023, 9:00 PM

Change 984493 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.10] Protect against ParserOutput re-namespacing

https://gerrit.wikimedia.org/r/984493

Mentioned in SAL (#wikimedia-operations) [2023-12-20T21:07:08Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:984493|Protect against ParserOutput re-namespacing (T353835)]]

Mentioned in SAL (#wikimedia-operations) [2023-12-20T21:08:41Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:984493|Protect against ParserOutput re-namespacing (T353835)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Change 984637 merged by jenkins-bot:

[mediawiki/core@master] Protect against ParserOutput re-namespacing

https://gerrit.wikimedia.org/r/984637

Mentioned in SAL (#wikimedia-operations) [2023-12-20T21:15:22Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:984493|Protect against ParserOutput re-namespacing (T353835)]] (duration: 08m 13s)

Ladsgroup closed this task as Resolved.Dec 20 2023, 9:16 PM

Ladsgroup assigned this task to cscott.

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.12; 2024-01-02); removed MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 20 2023, 10:00 PM

Change 984636 merged by jenkins-bot:

[mediawiki/core@master] Be more aggressive in protecting against unserialization issues

https://gerrit.wikimedia.org/r/984636

Maintenance_bot removed a project: Patch-For-Review.Dec 20 2023, 10:30 PM

cscott added a parent task: T353883: JsonCodec should be robust against class aliases.Dec 21 2023, 3:10 PM

cscott mentioned this in T378006: Cannot declare class CacheTime, because the name is already in use in CacheTime.php.Oct 23 2024, 10:51 PM

Change #1162975 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_39] Protect against ParserOutput re-namespacing

https://gerrit.wikimedia.org/r/1162975