Page MenuHomePhabricator
Create Task
Maniphest T353985

Deprecated usage of PrefixSearchBackend hook
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  1. Set up a new instance of Mediawiki 1.41.0
  2. Enable Extension:TitleKey
  3. See the Deprecation Warning below

What happens?:

When using this extension with mediawiki 1.41.0 (latest stable) this is creating the following deprecation warning:

Deprecated: Use of PrefixSearchBackend hook (used in TitleKey::prefixSearchBackend) was deprecated in MediaWiki 1.27. [Called from MediaWiki\HookContainer\HookContainer::register in /app/includes/HookContainer/HookContainer.php at line 438] in /app/includes/debug/MWDebug.php on line 386

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):
1.41.0

Other information (browser name/version, screenshots, etc.):

Screenshot 2023-12-23 at 18-18-43 Test.png (939×1 px, 196 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Drag the extension somewhat up to date...mediawiki/extensions/TitleKeyREL1_42+158 -109
TitleKey prefixsearch has to override each backendmediawiki/extensions/TitleKeyREL1_42+104 -0
TitleKey prefixsearch has to override each backendmediawiki/extensions/TitleKeymaster+30 -7
REL1_41 should not use 1.42 getConnectionProvider()mediawiki/extensions/TitleKeymaster+4 -4
Drag the extension somewhat up to date...mediawiki/extensions/TitleKeymaster+158 -109
Customize query in gerrit

Related Objects

Event Timeline

ChristianHeusel created this task.Dec 23 2023, 5:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 23 2023, 5:19 PM
ChristianHeusel added a project: MediaWiki-extensions-TitleKey.Dec 23 2023, 5:27 PM
gerritbot added a comment.Dec 24 2023, 10:10 PM

Change 985385 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/TitleKey@master] Drag the extension somewhat up to date...

https://gerrit.wikimedia.org/r/985385

gerritbot added a project: Patch-For-Review.Dec 24 2023, 10:10 PM
Raymond subscribed.Jan 8 2024, 11:07 AM
Prod subscribed.May 3 2024, 2:55 AM
TheDJ added a project: Wikimedia-Hackathon-2024.May 3 2024, 4:02 PM
gerritbot added a comment.May 4 2024, 8:21 AM

Change #985385 merged by jenkins-bot:

[mediawiki/extensions/TitleKey@master] Drag the extension somewhat up to date...

https://gerrit.wikimedia.org/r/985385

Maintenance_bot removed a project: Patch-For-Review.May 4 2024, 8:30 AM
Aklapper closed this task as Resolved.May 7 2024, 10:55 AM
Aklapper assigned this task to Reedy.
Aklapper moved this task from Backlog to Hacking projects on the Wikimedia-Hackathon-2024 board.
TheDJ subscribed.EditedMay 24 2024, 11:17 AM

User giving feedback that this works, but the maintenance script depends on 1.42. Using getDBLoadBalancerFactory instead of getConnectionProvider would fix this and fixing that might be valuable (as well as back porting to 1.39 ). extension.json claims 1.39 compatibility.

TheDJ reopened this task as Open.May 24 2024, 11:18 AM
TheDJ added a project: User-TheDJ.
gerritbot added a comment.May 24 2024, 9:30 PM

Change #1035832 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TitleKey@master] REL1_41 should not use 1.42 getConnectionProvider()

https://gerrit.wikimedia.org/r/1035832

gerritbot added a project: Patch-For-Review.May 24 2024, 9:30 PM
gerritbot added a comment.May 25 2024, 12:58 PM

Change #1035832 merged by jenkins-bot:

[mediawiki/extensions/TitleKey@master] REL1_41 should not use 1.42 getConnectionProvider()

https://gerrit.wikimedia.org/r/1035832

Maintenance_bot removed a project: Patch-For-Review.May 25 2024, 1:30 PM
TheDJ closed this task as Resolved.May 25 2024, 9:16 PM
TheDJ reopened this task as Open.May 27 2024, 12:57 PM
TheDJ added a comment.May 27 2024, 2:44 PM

This breaks the search engine.

Reading more and more of this code (and finally understanding it), I think this deprecation is actually problematic. It should have been replaced with a better hook, instead of removed and 'build your own entire search backend for all types of search'

Also considering adding a collation option to core, but this might not be performant enough in day to day operations for some of the wikis which currently use the title key extension ?

gerritbot added a comment.May 27 2024, 9:12 PM

Change #1036312 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TitleKey@master] TitleKey prefixsearch has to override each backend

https://gerrit.wikimedia.org/r/1036312

gerritbot added a project: Patch-For-Review.May 27 2024, 9:12 PM
Krinkle mentioned this in T366091: Convert TitleKey schema to abstract schema.May 28 2024, 4:37 PM
TheDJ moved this task from Inbox to For-review on the User-TheDJ board.Jul 15 2024, 7:15 PM
gerritbot added a comment.Jul 24 2024, 1:19 PM

Change #1036312 merged by jenkins-bot:

[mediawiki/extensions/TitleKey@master] TitleKey prefixsearch has to override each backend

https://gerrit.wikimedia.org/r/1036312

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2024, 1:31 PM
gerritbot added a comment.Aug 16 2024, 2:54 PM

Change #1063214 had a related patch set uploaded (by MarkAHershberger; author: TheDJ):

[mediawiki/extensions/TitleKey@REL1_42] TitleKey prefixsearch has to override each backend

https://gerrit.wikimedia.org/r/1063214

gerritbot added a project: Patch-For-Review.Aug 16 2024, 2:54 PM
gerritbot added a comment.Aug 16 2024, 3:26 PM

Change #1063214 abandoned by MarkAHershberger:

[mediawiki/extensions/TitleKey@REL1_42] TitleKey prefixsearch has to override each backend

https://gerrit.wikimedia.org/r/1063214

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2024, 3:30 PM
gerritbot added a comment.Aug 25 2024, 9:12 AM

Change #1065748 had a related patch set uploaded (by TheDJ; author: Reedy):

[mediawiki/extensions/TitleKey@REL1_42] Drag the extension somewhat up to date...

https://gerrit.wikimedia.org/r/1065748

gerritbot added a project: Patch-For-Review.Aug 25 2024, 9:12 AM
gerritbot added a comment.Aug 25 2024, 5:10 PM

Change #1065748 merged by jenkins-bot:

[mediawiki/extensions/TitleKey@REL1_42] Drag the extension somewhat up to date...

https://gerrit.wikimedia.org/r/1065748

TheDJ closed this task as Resolved.Aug 25 2024, 6:42 PM
TheDJ added a comment.Aug 25 2024, 6:45 PM

I don't really feel like backporting this all the way to 1.41. It's only a deprecation warning after all.

Samwilson mentioned this in T377286: Simplify installation to not need to set $wgSearchType.Oct 15 2024, 11:43 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 16 2024, 12:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits