Page MenuHomePhabricator

Allow deleting data from Special:EditRecovery
Open, LowPublicFeature

Description

Feature summary:
A button that deletes saved data on Special:EditRecovery. Compare "Unsubscribe" button on Special:TopicSubscriptions.

Use case(s):
When I want to delete multiple saved edits at once, I have to click "edit" and then "Discard changes" page by page.

Task Description:

QA Results - Beta

ACStatusDetails
1T353996#9792264

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Good idea! This is already listed as part of T347673.

JWheeler-WMF moved this task from Up Next (June 3-21) to Backlog on the Community-Tech board.
JWheeler-WMF subscribed.

This is a great idea, however it feels like an advanced feature optimization, and we aren't sure how many people will visit the Special:EditRecovery page and/or discard their edits. As such, I'm going to categorize this as "follow-on" work

IKhitron subscribed.

There are much more cases when this needed, see here.

Change #1019761 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/core@master] SpecialEditRecovery: Add deletion

https://gerrit.wikimedia.org/r/1019761

Change #1019761 merged by jenkins-bot:

[mediawiki/core@master] SpecialEditRecovery: Add deletion

https://gerrit.wikimedia.org/r/1019761

Well, there is a new button "delete" on mediawiki.org. Clicking on it makes the item disappear. Refreshing Special:EditRecovery brings everything back. Houston, we have a problem.

Change #1020610 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Edit Recovery: delete by key, rather than looping through all

https://gerrit.wikimedia.org/r/1020610

@IKhitron eek yes! I can't reliably reproduce this, but have been able to a few times. :-( I'm thinking that it's related to how we're deleting the record by looping through all records and finding the matching one; I've made a patch for that (hope you don't mind me jumping in here @TheresNoTime).

(By the way @IKhitron, the file you attached is restricted; could you change its visibility?)

(By the way @IKhitron, the file you attached is restricted; could you change its visibility?)

Never thought it's possible. I never restricted it, just uploaded on Phabricator. What should I do?
Until than you can watch it here, I hope.

Reproductible on my side.

@TheresNoTime I got a couple of issues when I clicked on the Back button for all of Local and only Safari with Beta as seen in the Issues section. The rest of Beta is fine as seen in the videos.

Status: ❌ FAIL
Environment: Local: 1.43.0-alpha (ce9d259)17:11, 22 April 2024; Beta: 1.43.0-alpha (ce9d259)
OS: macOS Sonoma 14.4.1
Browser: Chrome 123, Firefox 124, Safari 17.4
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Lightsaber&action=edit
Special:EditRecovery

✅AC1: https://phabricator.wikimedia.org/T353996

Local- RefreshLocal- Paste
Beta-Chrome Back ButtonBeta- Chrome RefreshBeta- Chrome Paste
Firefox- Beta Back Button

❌Issues

  1. |❌Local-Back Button -Edit recovery comes back even when deleted in Special:EditRecovery for Chrome, Firefox & Safari in Local
  1. |❌Safari- Beta Back Button- Edit recovery comes back even when deleted in Special:EditRecovery for only Safari in Beta. Chrome and Firefox are fine.

Change #1020610 merged by jenkins-bot:

[mediawiki/core@master] Edit Recovery: delete by key, rather than looping through all

https://gerrit.wikimedia.org/r/1020610

I hope it will work soon, because now I can't delete any item, not just some.

@TheresNoTime I'm still getting the same issues as before which can be seen in the videos below. If you have any questions about them, please let me know, thanks!

Status: ❌ FAIL
Environment: Beta: 1.43.0-alpha (1545736); Local: 1.43.0-alpha (37abdfd) 18:58, 13 May 2024
OS: macOS Sonoma 14.4.1
Browser: Chrome 124, Safari 17.4.1
Skins. Beta- Vector 2022; Local: Vector 2010
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:8080/wiki/Cat
https://en.wikipedia.beta.wmflabs.org/wiki/Lightsaber

❌Issues

  1. |❌Local-Back Button -Edit recovery comes back even when deleted in Special:EditRecovery for Chrome, Firefox & Safari in Local

  1. |❌Safari- Beta Back Button- Edit recovery comes back even when deleted in Special:EditRecovery for only Safari in Beta. Chrome and Firefox are fine.