Page MenuHomePhabricator
Create Task
Maniphest T354028

Add copy button to recovery codes page
Closed, ResolvedPublic
Actions

Description

Related to T245027: Enable downloading recovery codes for two-factor (TOTP), potentially add a "copy" button to the 2FA recovery codes screen.

Screenshot 2023-12-26 at 21.35.14.png (1×846 px, 103 KB)

Them embed it into the value (tokens purposefully changed)...

<clipboard-copy data-ga-click="2FA, copy recovery codes, view 2fa recovery codes form" data-action="click:recovery-codes#saveCodes" aria-label="Copy" value="eed12-c8f7a 
12345-67890 
12345-67890 
12345-67890 
12345-67890 
12345-67890 
12345-67890 
12345-67890 
12345-67890 
12345-67890 
12345-67890 
12345-67890 
12345-67890 
12345-67890 
12345-67890 
12345-67890" data-view-component="true" class="btn recovery-code-save-button" tabindex="0" role="button">
    
          <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-copy">
    <path d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 0 1 0 1.5h-1.5a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-1.5a.75.75 0 0 1 1.5 0v1.5A1.75 1.75 0 0 1 9.25 16h-7.5A1.75 1.75 0 0 1 0 14.25Z"></path><path d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0 1 14.25 11h-7.5A1.75 1.75 0 0 1 5 9.25Zm1.75-.25a.25.25 0 0 0-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 0 0 .25-.25v-7.5a.25.25 0 0 0-.25-.25Z"></path>
</svg>
          Copy

</clipboard-copy>

Details

Other Assignee
TheDJ
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Do not make Copy button the default submit action on TOTP formmediawiki/extensions/OATHAuthREL1_43+2 -1
Do not make Copy button the default submit action on TOTP formmediawiki/extensions/OATHAuthmaster+2 -1
Add copy button for recovery codesmediawiki/extensions/OATHAuthREL1_43+106 -18
Add copy button for recovery codesmediawiki/extensions/OATHAuthmaster+106 -18
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT100375 Improve user experience of Two-Factor process
 OpenNoneT352856 Recovery code improvements
 ResolvedReedyT354028 Add copy button to recovery codes page

Event Timeline

Reedy created this task.Dec 26 2023, 9:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 26 2023, 9:38 PM
Reedy added a parent task: T352856: Recovery code improvements.Dec 26 2023, 9:38 PM
Reedy moved this task from Backlog to User Experience on the MediaWiki-extensions-OATHAuth board.Dec 26 2023, 9:43 PM
Reedy renamed this task from Add copy button to scratch token page to Add copy button to recovery codes page.Jan 1 2024, 8:51 PM
Reedy updated the task description. (Show Details)
gerritbot added a comment.Jan 11 2024, 10:45 PM

Change 989963 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] WIP: Add copy button for recovery codes

https://gerrit.wikimedia.org/r/989963

gerritbot added a project: Patch-For-Review.Jan 11 2024, 10:45 PM
TheDJ subscribed.EditedNov 2 2024, 6:42 PM

Screenshot 2024-11-02 at 17.24.44.png (966×1 px, 210 KB)
Screenshot 2024-11-02 at 17.24.50.png (1×2 px, 846 KB)

[edit] Just in case anyone is wondering, these are codes in my docker instance, and have already been regenerated several times

gerritbot added a comment.Nov 11 2024, 8:43 PM

Change #989963 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Add copy button for recovery codes

https://gerrit.wikimedia.org/r/989963

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).Nov 11 2024, 9:00 PM
gerritbot added a comment.Nov 11 2024, 9:28 PM

Change #1089862 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_43] Add copy button for recovery codes

https://gerrit.wikimedia.org/r/1089862

Reedy closed this task as Resolved.Nov 11 2024, 9:29 PM
Reedy claimed this task.
Reedy updated Other Assignee, added: TheDJ.
gerritbot added a comment.Nov 11 2024, 9:41 PM

Change #1089862 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_43] Add copy button for recovery codes

https://gerrit.wikimedia.org/r/1089862

Maintenance_bot removed a project: Patch-For-Review.Nov 11 2024, 10:30 PM
Tgr reopened this task as Open.Apr 6 2025, 5:10 PM
Tgr subscribed.

The copy button is now receiving submit actions via the Enter key (since it's first in document order), which isn't great.

gerritbot added a comment.Apr 6 2025, 9:01 PM

Change #1134381 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/OATHAuth@master] Do not make Copy button the default submit action on TOTP form

https://gerrit.wikimedia.org/r/1134381

gerritbot added a project: Patch-For-Review.Apr 6 2025, 9:01 PM
gerritbot added a comment.Apr 10 2025, 3:43 PM

Change #1134381 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Do not make Copy button the default submit action on TOTP form

https://gerrit.wikimedia.org/r/1134381

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.25; 2025-04-15); removed MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).Apr 10 2025, 4:00 PM
Reedy added a project: MW-1.43-release.Apr 10 2025, 4:04 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 10 2025, 4:32 PM
gerritbot added a comment.Apr 10 2025, 4:54 PM

Change #1135792 had a related patch set uploaded (by Reedy; author: Gergő Tisza):

[mediawiki/extensions/OATHAuth@REL1_43] Do not make Copy button the default submit action on TOTP form

https://gerrit.wikimedia.org/r/1135792

gerritbot added a project: Patch-For-Review.Apr 10 2025, 4:54 PM
Reedy closed this task as Resolved.Apr 10 2025, 5:48 PM
gerritbot added a comment.Apr 10 2025, 6:49 PM

Change #1135792 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_43] Do not make Copy button the default submit action on TOTP form

https://gerrit.wikimedia.org/r/1135792

Maintenance_bot removed a project: Patch-For-Review.Apr 10 2025, 7:31 PM
Tgr mentioned this in T354029: Add print button to recovery code page.Aug 1 2025, 3:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits