Page MenuHomePhabricator
Create Task
Maniphest T354184

Can't locally disable live preview
Closed, InvalidPublicBUG REPORT
Actions

Description

Steps to replicate the issue:

  • In GlobalPreferences, enable "Show preview without reloading the page" and click Save
  • In Preferences, uncheck "Show preview without reloading the page" after checking "Set a local exception for this global preference" below it, and click Save
  • Start editing a page and click "Show diff" or "Show preview"

What happens?:
The preview or diff appears without reloading the page (i.e. live preview is on).

What should have happened instead?:
Clicking the button navigates to a new page (live preview is off).

Other information:
mw.user.options.get('uselivepreview') is set to the expected 0, but the module mediawiki.action.edit.preview is nonetheless loaded. This suggests $this->userOptionsLookup->getOption( $user, 'uselivepreview' ) here is not working as expected.

Related Objects

Event Timeline

Nardog created this task.Jan 2 2024, 12:51 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptJan 2 2024, 12:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Nardog updated the task description. (Show Details)Jan 2 2024, 12:55 PM
dmaza moved this task from New & TBD Tickets to Up Next (June 3-21) on the Community-Tech board.Jan 24 2024, 3:00 PM
TheresNoTime moved this task from Up Next (June 3-21) to CommTech-Kanban on the Community-Tech board.Feb 19 2024, 1:17 PM
TheresNoTime edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.
TheresNoTime claimed this task.Feb 19 2024, 2:23 PM
TheresNoTime moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.
TheresNoTime subscribed.

Hey @Nardog — which wiki did you see this behaviour on?
I've attempted to replicate per the below steps locally, on the beta cluster and on test.wikipedia and it appears to be behaving as expected.
Could you confirm you're still seeing the issue, as in the meantime something may have changed.

Replication attempt steps

  1. I went to my Global Preferences, and enabled "Show preview without reloading the page". I clicked save.
  2. I navigated to my sandbox, clicked edit, and clicked "Preview".
  3. I noted that the preview appears without reloading the page. [expected behaviour]
  4. I went to my (Local) Preferences, clicked "Set a local exception for this global preference" and then disabled "Show preview without reloading the page". I clicked save.
  5. I navigated to my sandbox, clicked edit, and clicked "Preview"
  6. I noted that the page navigated to the preview. [expected behaviour]
Nardog closed this task as Invalid.Feb 19 2024, 4:46 PM

My bad, my prototype for T136907 was loading the module. Not reproducible with safemode=1. Apologies for taking your time 😳

MusikAnimal moved this task from In Development 💻 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.Apr 10 2024, 4:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits