Page MenuHomePhabricator

Do not use mw.loader.require, use require
Closed, ResolvedPublicBUG REPORT

Description

The mw.loader.require is marked as a private function. It supports a debugging utility but it is not a supported interface.

It is currently being referenced in several places here:
https://codesearch.wmcloud.org/search/?q=mw.loader.require&files=&excludeFiles=&repos=#Extension:TimedMediaHandler

Related: T235198

Event Timeline

Change 992742 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] [WIP] Don't use mw.loader.require

https://gerrit.wikimedia.org/r/992742

Change 992742 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Don't use mw.loader.require directly

https://gerrit.wikimedia.org/r/992742

Change 993023 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Missed one require for InlinePlayer

https://gerrit.wikimedia.org/r/993023

Change 993023 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Missed one require for InlinePlayer

https://gerrit.wikimedia.org/r/993023

TheDJ claimed this task.