@DMburugu I'm not moving this task back to Needs Discussion, but I feel like it needs clarifying what should be the behaviour for redirects. Should they not appear in the page views list at all? Or should we calculate the page views for the redirect (aka how many users accessed the redirect itself)? I think the first choice (not displaying redirects at all) is better, since what "pageview for redirect" means is presumably fairly difficult to gasp for most module users (especially since clicking on the link would resolve the redirect).

@KStoller-WMF Since you triaged this task, maybe you already have a clear opinion on what should be happening in this case?

@taavi Also, if you have any thoughts on what end behaviour would be the best here, we'd be glad to hear it :).

Thanks for asking for additional info here! I agree that it's best to not display redirects. I added these details to the task:

Product perspective: the Impact Module view count data is meant to only reflect Article edits (we even use the "Views on articles you've edited" language); redirects should not be included on the Impact module's "most viewed" list.

Acceptance Criteria:
Given I am viewing my Impact Module,
When I have edited a redirect,
Then the redirect is not included in the Impact Module's "Most viewed" list.

Thanks for reporting this @taavi, and definitely let us know if you disagree with that approach. Thanks!

Change #1179248 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/GrowthExperiments@master] ComputedUserImpactLookup: Ignore redirect pages

https://gerrit.wikimedia.org/r/1179248

Change #1179248 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ComputedUserImpactLookup: Ignore redirect pages

https://gerrit.wikimedia.org/r/1179248