Page MenuHomePhabricator

Prevent pinnable element scrollbar from appearing above the pinnable element title
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

Due to the way the spacing on the pinnable element is implemented, it looks like this when the scrollbar is present

Screenshot 2024-01-02 at 1.19.53 PM.png (408×578 px, 52 KB)

Screenshot 2024-01-02 at 1.23.45 PM.png (190×1 px, 53 KB)

TODO

We could move the spacing from the pinnable element to its container to get something like this:

Screenshot 2024-01-02 at 1.20.10 PM.png (384×588 px, 51 KB)

Screenshot 2024-01-02 at 1.23.32 PM.png (314×1 px, 72 KB)

QA Results - Prod

ACStatusDetails
1T354431#9601140

Event Timeline

Change 979392 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Move pinnable element spacing from the pinnable element to the container

https://gerrit.wikimedia.org/r/979392

Jdlrobson lowered the priority of this task from High to Medium.Jan 18 2024, 6:40 PM
Jdlrobson set the point value for this task to 2.
Jdlrobson updated Other Assignee, added: bwang.
Jdlrobson subscribed.

Jan could you please review?

Jdlrobson lowered the priority of this task from Medium to Low.Feb 14 2024, 6:15 PM

Change 979392 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Move pinnable element spacing from the pinnable element to the container

https://gerrit.wikimedia.org/r/979392

I tested this in beta, it looks good to me

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Verify the the spacing from the pinnable element is moved to its container to prevent the scrollbar from appearing above the pinnable element title

screenshot 621.png (365×1 px, 158 KB)

Edtadros subscribed.

This was verified only in Prod in the previous deployment, it just needs someone other than me to sign it off.

ovasileva claimed this task.