Page MenuHomePhabricator
Create Task
Maniphest T354433

1.42.0-wmf.15 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jnuche
Release Version
1.42.0-wmf.15
Release Date
Jan 22 2024, 12:00 AM

2024 week 04 1.42-wmf.15 Changes wmf/1.42.0-wmf.15

This MediaWiki Train Deployment is scheduled for the week of Monday, January 22nd:

Monday January 22ndTuesday, January 23rdWednesday, January 24thThursday, January 25thFriday
Backports only.Branch wmf.15 and deploy to Group 0 Wikis.Deploy wmf.15 to Group 1 Wikis.Deploy wmf.15 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.15 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.42.0-wmf.14
Next: 1.42.0-wmf.16
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more"mediawiki/skins/Vectormaster+10 -35
group2 wikis to 1.42.0-wmf.15operations/mediawiki-configmaster+333 -333
Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more"mediawiki/skins/Vectorwmf/1.42.0-wmf.15+10 -35
group1 wikis to 1.42.0-wmf.15operations/mediawiki-configmaster+549 -549
Revert "group1 wikis to 1.42.0-wmf.15"operations/mediawiki-configmaster+549 -549
group1 wikis to 1.42.0-wmf.15operations/mediawiki-configmaster+549 -549
group0 wikis to 1.42.0-wmf.15operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.42.0-wmf.15operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.42.0-wmf.15mediawiki/corewmf/1.42.0-wmf.15+991 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Jan 5 2024, 6:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2024, 6:13 PM
• NoOnEtHeMaStA added a commit: rMEXTf658c3375869: Update git submodules.Jan 7 2024, 9:15 PM
Aklapper removed a commit: rMEXTf658c3375869: Update git submodules.Jan 7 2024, 9:25 PM
thcipriani assigned this task to hashar.Jan 18 2024, 11:37 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jnuche.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
Jdlrobson mentioned this in T355379: Verify 1.42.0-wmf.15 deployment.Jan 19 2024, 12:41 AM
gerritbot added a comment.Jan 23 2024, 3:07 AM

Change 992179 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.42.0-wmf.15] Branch commit for wmf/1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992179

gerritbot added a project: Patch-For-Review.Jan 23 2024, 3:07 AM
gerritbot added a comment.Jan 23 2024, 3:25 AM

Change 992179 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.15] Branch commit for wmf/1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992179

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2024, 3:30 AM
gerritbot added a comment.Jan 23 2024, 4:01 AM

Change 992273 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992273

gerritbot added a project: Patch-For-Review.Jan 23 2024, 4:01 AM

Change 992273 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992273

Stashbot added a comment.Jan 23 2024, 4:02 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-23T04:02:44Z] <mwpresync@deploy2002> Started scap: testwikis wikis to 1.42.0-wmf.15 refs T354433

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2024, 4:30 AM
Stashbot added a comment.Jan 23 2024, 4:54 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-23T04:54:07Z] <mwpresync@deploy2002> Finished scap: testwikis wikis to 1.42.0-wmf.15 refs T354433 (duration: 51m 22s)

kostajh subscribed.Jan 23 2024, 6:58 AM

@hashar https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/992123 (and possibly also https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/992277/2) will need a backport to wmf.15.

gerritbot added a comment.Jan 23 2024, 9:15 AM

Change 992363 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992363

gerritbot added a project: Patch-For-Review.Jan 23 2024, 9:15 AM

Change 992363 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992363

Stashbot added a comment.Jan 23 2024, 9:24 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-23T09:24:04Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group0 wikis to 1.42.0-wmf.15 refs T354433

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2024, 9:30 AM
hashar added a subtask: T355680: InvalidArgumentException: Passing a raw callable is not allowed here. Use [ 'factory' => $callable ] instead..Jan 23 2024, 2:45 PM
hashar removed a subtask: T355698: redirectMsg mostly obscured in Vector-2022 in wmf.15.Jan 24 2024, 8:23 AM
hashar closed subtask T355680: InvalidArgumentException: Passing a raw callable is not allowed here. Use [ 'factory' => $callable ] instead. as Resolved.Jan 24 2024, 8:40 AM
gerritbot added a comment.Jan 24 2024, 9:11 AM

Change 992630 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992630

gerritbot added a project: Patch-For-Review.Jan 24 2024, 9:11 AM

Change 992630 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992630

Stashbot added a comment.Jan 24 2024, 9:20 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-24T09:20:15Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group1 wikis to 1.42.0-wmf.15 refs T354433

Stashbot added a comment.Jan 24 2024, 9:27 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-24T09:27:10Z] <hashar@deploy2002> Synchronized php: group1 wikis to 1.42.0-wmf.15 refs T354433 (duration: 06m 55s)

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2024, 9:30 AM
hashar added a subtask: T355751: TypeError: Argument 1 passed to MediaWiki\Parser\Sanitizer::escapeHtmlAllowEntities() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.15/extensions/Echo/includes/DiscussionParser.php on line 1299.Jan 24 2024, 10:02 AM
gerritbot added a comment.Jan 24 2024, 10:25 AM

Change 992634 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/mediawiki-config@master] Revert "group1 wikis to 1.42.0-wmf.15"

https://gerrit.wikimedia.org/r/992634

gerritbot added a project: Patch-For-Review.Jan 24 2024, 10:25 AM

Change 992634 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "group1 wikis to 1.42.0-wmf.15"

https://gerrit.wikimedia.org/r/992634

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2024, 10:30 AM
Stashbot added a comment.Jan 24 2024, 10:31 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-24T10:31:53Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: Revert "group1 wikis to 1.42.0-wmf.15" - T354433

hashar added a comment.Jan 24 2024, 3:49 PM

I am pushing the fix for Echo which would address the blocker T355751. We can then resume the train.

hashar closed subtask T355751: TypeError: Argument 1 passed to MediaWiki\Parser\Sanitizer::escapeHtmlAllowEntities() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.15/extensions/Echo/includes/DiscussionParser.php on line 1299 as Resolved.Jan 24 2024, 5:00 PM
DLynch subscribed.Jan 24 2024, 5:04 PM

Got a possible blocker in T355805 which is making the 2017 wikitext editor unusable with syntax highlighting.

gerritbot added a comment.Jan 24 2024, 5:07 PM

Change 992759 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992759

gerritbot added a project: Patch-For-Review.Jan 24 2024, 5:07 PM

Change 992759 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992759

Stashbot added a comment.Jan 24 2024, 5:16 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-24T17:16:48Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group1 wikis to 1.42.0-wmf.15 refs T354433

Stashbot added a comment.Jan 24 2024, 5:23 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-24T17:23:58Z] <hashar@deploy2002> Synchronized php: group1 wikis to 1.42.0-wmf.15 refs T354433 (duration: 07m 10s)

hashar added a comment.Jan 24 2024, 5:26 PM

LiquidThreads has an issue similar to T355751 which I have filed as T355808 but I haven't marked as a blocker.

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2024, 5:31 PM
taavi added a subtask: T355813: CentralAuth doesn't shows user rights correctly.Jan 24 2024, 7:22 PM
DLynch added a subtask: T355805: Syntax highlighting in 2017 wikitext editor has extreme vertical cursor displacement.Jan 24 2024, 7:37 PM
gerritbot added a comment.Jan 24 2024, 8:31 PM

Change 992774 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more"

https://gerrit.wikimedia.org/r/992774

gerritbot added a project: Patch-For-Review.Jan 24 2024, 8:31 PM
gerritbot added a comment.Jan 24 2024, 10:27 PM

Change 992774 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more"

https://gerrit.wikimedia.org/r/992774

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2024, 10:30 PM
gerritbot added a comment.Jan 24 2024, 10:34 PM

Change 992775 had a related patch set uploaded (by Jforrester; author: Jdrewniak):

[mediawiki/skins/Vector@wmf/1.42.0-wmf.15] Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more"

https://gerrit.wikimedia.org/r/992775

gerritbot added a project: Patch-For-Review.Jan 24 2024, 10:34 PM
gerritbot added a comment.Jan 24 2024, 11:18 PM

Change 992775 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.42.0-wmf.15] Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more"

https://gerrit.wikimedia.org/r/992775

Stashbot mentioned this in T355805: Syntax highlighting in 2017 wikitext editor has extreme vertical cursor displacement.Jan 24 2024, 11:19 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-24T23:19:29Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:992775|Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more" (T355805 T354433)]]

Stashbot added a comment.Jan 24 2024, 11:21 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-24T23:21:01Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:992775|Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more" (T355805 T354433)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Jdforrester-WMF added a subtask: T355698: redirectMsg mostly obscured in Vector-2022 in wmf.15.Jan 24 2024, 11:28 PM
Jdforrester-WMF closed subtask T355805: Syntax highlighting in 2017 wikitext editor has extreme vertical cursor displacement as Resolved.
Maintenance_bot removed a project: Patch-For-Review.Jan 24 2024, 11:30 PM
Stashbot added a comment.Jan 24 2024, 11:33 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-24T23:32:59Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:992775|Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more" (T355805 T354433)]] (duration: 13m 29s)

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 25 2024, 12:00 AM
hashar closed subtask T355813: CentralAuth doesn't shows user rights correctly as Resolved.Jan 25 2024, 11:32 AM
gerritbot added a comment.Jan 25 2024, 1:04 PM

Change 992927 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992927

gerritbot added a project: Patch-For-Review.Jan 25 2024, 1:04 PM

Change 992927 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.15

https://gerrit.wikimedia.org/r/992927

Stashbot added a comment.Jan 25 2024, 1:12 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-25T13:12:47Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group2 wikis to 1.42.0-wmf.15 refs T354433

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2024, 1:31 PM
hashar closed this task as Resolved.Jan 25 2024, 5:25 PM

I am claiming 1.42.0-wmf.15 to be a success. Thank you for all the patches, tasks filed etc :)

taavi subscribed.Jan 28 2024, 9:56 PM

T356024 is a new issue introduced in this train.

gerritbot added a comment.Jan 29 2024, 6:37 PM

Change 993505 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more (attempt 2)

https://gerrit.wikimedia.org/r/993505

gerritbot added a project: Patch-For-Review.Jan 29 2024, 6:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits