Maniphest T354476

PageTriage does not immediately show copyvio issue on tagging
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Soda
	Jan 6 2024, 2:55 PM

Project Tags

Referenced Files

None

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Tag a revision of a page using the pagetriagetagcopyvio API
Open the article that has the tagged revision

What happens?:
Copyvio tag does not show up

What should have happened instead?:
Copyvio tags should show up immediately

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Reset cache after tagging as copyvio	Sohom Datta	mediawiki/extensions/PageTriage	master	+9 -2

Customize query in gerrit

Event Timeline

Soda created this task.Jan 6 2024, 2:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2024, 2:55 PM

Change 988141 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Reset cache after tagging as copyvio

https://gerrit.wikimedia.org/r/988141

gerritbot added a project: Patch-For-Review.Jan 6 2024, 2:56 PM

Change 988141 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Reset cache after tagging as copyvio

https://gerrit.wikimedia.org/r/988141

Maintenance_bot removed a project: Patch-For-Review.Jan 6 2024, 4:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 6 2024, 6:00 PM

• NoOnEtHeMaStA added a commit: rMEXTf658c3375869: Update git submodules.Jan 7 2024, 9:15 PM

Aklapper removed a commit: rMEXTf658c3375869: Update git submodules.Jan 7 2024, 9:24 PM

Despite Sohom's patch, I am still having issues with the copyvio tag displaying in Special:NewPagesFeed and the Page Curation toolbar info flyout immediately after an API query. If I review then unreview the article, I can force a refresh.

Novem_Linguae moved this task from Backlog to Priority bugs on the PageTriage board.Jan 13 2024, 5:18 PM

Maybe we need to do this:

$acp = ArticleCompileProcessor::newFromPageId( [
	$page->getId()
] );
$acp->compileMetadata();

Instead of or in addition to what we did in the previous patch:

$metadata = new ArticleMetadata( [ $pageId ] );
$metadata->flushMetadataFromCache();

Never mind. I think it was a rebase problem with the patch I was working on. Is working now.

Novem_Linguae moved this task from Priority bugs to Waiting for enwiki deploy on the PageTriage board.Jan 13 2024, 6:23 PM

Based on a few tests wrt to EranBot this appears to work.