Page MenuHomePhabricator

$wgCookieSecure = 'detect' fails when $wgServer is protocol-relative
Closed, ResolvedPublic

Description

Snippet from Setup:

if ( $wgCookieSecure === 'detect' ) {
$wgCookieSecure = ( substr( $wgServer, 0, 6 ) === 'https:' );
}

Should probably use WebRequest::detectProtocol() instead.


Version: unspecified
Severity: normal

Details

Reference
bz33471

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:05 AM
bzimport set Reference to bz33471.
bzimport added a subscriber: Unknown Object (MLST).

WebRequest::detectProtocol() returns the string 'https' (without a colon).