Page MenuHomePhabricator

[builds-cli] --debug option behaviour is confusing
Open, LowPublicBUG REPORT

Description

Current behaviour

$ toolforge build list --debug

Fails with 'no such option: --debug'.

$ toolforge --debug build list

Shows debug for te command discovery phase only.

$ toolforge build --debug list

Works!

Ideally all three would be do the same thing, but at least the ones that don't throw an error should be fixed to behave in the same way.

Event Timeline

taavi changed the subtype of this task from "Task" to "Bug Report".Jan 10 2024, 10:05 AM
dcaro renamed this task from builds-cli --debug option behaviour is confusing to [builds-cli] --debug option behaviour is confusing.Mar 5 2024, 11:40 AM
dcaro subscribed.

I think this might be a regression, we should be using environment variables from the main toolforge cli to pass down the debug flags too, though toolforge build --debug and toolforge --debug list can be interpreted as different (debugging different levels of the cli, one starting at the top, the other at the list subcommand).

dcaro triaged this task as Low priority.Mar 5 2024, 11:42 AM
dcaro edited projects, added Toolforge; removed Toolforge Build Service.
dcaro moved this task from Backlog to Ready to be worked on on the Toolforge board.