Page MenuHomePhabricator

Upgrade to Gerrit 3.7
Closed, ResolvedPublic

Description

This task is to upgrade to 3.7.x series

Release notes https://www.gerritcodereview.com/3.7.html

notes

breaking changes

To be checked https://www.gerritcodereview.com/3.7.html#breaking-changes

Change 334467: Removed support for deprecated approval config fields in label configs

Moved to its own task T355068, the new syntax is supported in 3.6 and thus the migration can be done ahead of upgrading to Gerrit 3.7.

Issue 15941: Fix SSH queries to not show commit-message unless –commit-message is provided

This issue has existed for several years and should be considered breaking as users might expect commit message to be included by default in SSH query results. Obtaining the commit message is a costly operation as the commit data has to be loaded. So, showing it even when –commit-message is not provided degrades the performance of SSH queries.

Zuul passes --commit-message to some ssh queries it is performing, I am thus assuming they explicitly set the option whenever it is needed.

Event Timeline

Change 990125 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@wmf/stable-3.7] Gerrit 3.7.6 and rebuild plugins

https://gerrit.wikimedia.org/r/990125

Change 990125 merged by jenkins-bot:

[operations/software/gerrit@wmf/stable-3.7] Merge tag 'v3.7.6' into wmf/stable-3.7

https://gerrit.wikimedia.org/r/990125

hashar updated the task description. (Show Details)
hashar updated the task description. (Show Details)

Change 990138 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.7] Update Gerrit to v3.7.6 and rebuild plugins

https://gerrit.wikimedia.org/r/990138

Change 990138 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.7] Update Gerrit to v3.7.6 and rebuild plugins

https://gerrit.wikimedia.org/r/990138

$ java -jar bin/gerrit.war init --batch --skip-plugins
Migrating data to schema 185 ...
Migrating label configurations
... using 48 threads ...
... (0.609 s) migrated label configurations of 3% (100/2862) projects
... (0.689 s) migrated label configurations of 7% (200/2862) projects
... (0.775 s) migrated label configurations of 10% (300/2862) projects
... (0.815 s) migrated label configurations of 14% (400/2862) projects
... (0.882 s) migrated label configurations of 17% (500/2862) projects
... (0.941 s) migrated label configurations of 21% (600/2862) projects
... (0.978 s) migrated label configurations of 24% (700/2862) projects
... (1.031 s) migrated label configurations of 28% (800/2862) projects
... (1.074 s) migrated label configurations of 31% (900/2862) projects
... (1.146 s) migrated label configurations of 35% (1000/2862) projects
... (1.185 s) migrated label configurations of 38% (1100/2862) projects
... (1.219 s) migrated label configurations of 42% (1200/2862) projects
... (1.289 s) migrated label configurations of 45% (1300/2862) projects
... (1.382 s) migrated label configurations of 49% (1400/2862) projects
... (1.449 s) migrated label configurations of 52% (1500/2862) projects
... (1.572 s) migrated label configurations of 56% (1600/2862) projects
... (1.693 s) migrated label configurations of 59% (1700/2862) projects
... (1.729 s) migrated label configurations of 63% (1800/2862) projects
... (1.848 s) migrated label configurations of 66% (1900/2862) projects
... (1.901 s) migrated label configurations of 70% (2000/2862) projects
... (2.002 s) migrated label configurations of 73% (2100/2862) projects
... (2.046 s) migrated label configurations of 77% (2200/2862) projects
... (2.095 s) migrated label configurations of 80% (2300/2862) projects
... (2.135 s) migrated label configurations of 84% (2400/2862) projects
... (2.259 s) migrated label configurations of 87% (2500/2862) projects
... (2.334 s) migrated label configurations of 91% (2600/2862) projects
... (2.403 s) migrated label configurations of 94% (2700/2862) projects
... (2.575 s) migrated label configurations of 98% (2800/2862) projects
... (2.707 s) Migrated label configurations of all 2862 projects to schema 185
Initialized /var/lib/gerrit2/review_site

Mentioned in SAL (#wikimedia-operations) [2024-01-22T09:11:22Z] <hashar> Gerrit: reindexing all changes for 3.6 > 3.7 migration # T354885

Icinga downtime and Alertmanager silence (ID=e51413d8-1282-4a8d-9ae6-23fe479263fe) set by cgoubert@cumin1002 for 4:00:00 on 2 host(s) and their services with reason: Gerrit update

gerrit[1003,2002].wikimedia.org
Reindexing changes: changes: 99% (979933/980136), failed: 203, project-slices: 100% (3240/3240), Slicing projects: 100% (2862/2862), done    
[2024-01-22 09:22:44,510] [main] WARN  com.google.gerrit.server.index.change.AllChangesIndexer : Failed 203/980136 changes
Reindexed 980136 documents in changes index in 707.1s (1386.2/s)
Index changes in version 79 is ready
Reindexing projects:    100% (2862/2862)
Reindexed 2862 documents in projects index in 0.8s (3533.3/s)
Index projects in version 5 is ready

The failures are known issues (some missing patchsets and some changes metadata coming from Google upstream).

Mentioned in SAL (#wikimedia-operations) [2024-01-22T09:38:15Z] <hashar> Restarted Gerrit with upgraded version 3.7.6 # T354885