Page MenuHomePhabricator

(mw.track) migrate MediaWiki.RevisionSlider.timing.init to statslib
Open, Needs TriagePublic

Description

Follow the migration process as outlined below.

  • Secure/Conduct a code review.
  • Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
  • Verify that the changes have been successfully implemented.
  • Update the dashboard by replacing the old Graphite metric with the new Prometheus metric.

Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

Event Timeline

@colewhite, this metric is tracked in JS land using the mw.track() method (doc) in ResourceLoader. I'm not sure we have an equivalent for statsLib yet.

We may need to incorporate statsLib support in ResourceLoader so code in JS space can send stats. I'll Cc @Krinkle for some inputs or coordinate async.

We may need to incorporate statsLib support in ResourceLoader so code in JS space can send stats.

You're right, this is beyond the reach of StatsLib right now. On first glance, it also appears to suffer from the same unstructured interface that prevented an easy migration away from StatsD in the first place. :(

I'm not sure there's much we can do about this one until we identify a path forward. It needs some research.

colewhite renamed this task from migrate MediaWiki.RevisionSlider.timing.init to statslib to (mw.track) migrate MediaWiki.RevisionSlider.timing.init to statslib.Thu, Apr 4, 2:48 PM