Page MenuHomePhabricator

Copy changes for dashboard emails
Open, Needs TriagePublic

Description

Type of request

  • Bug fix
  • Code review
  • Development work (writing code)
  • Deployment

Description

Code is done - needs review and deploy -> dev -> prod. This is for copy edits to automated emails in auth/infra repo.

MR9 in infrastructure/auth

Does this ticket impact Marketing OKRs?

  • Yes
  • No

If yes, Please briefly describe how and the OKR number.

We've edited copy for users in app emails already, this change aligns with those.
KR2 && 4

Priority

high, but not critical.

Requested implementation date

30 Sep

Event Timeline

Priority == high but not critical
Difficulty == easy

JArguello-WMF updated the task description. (Show Details)
JArguello-WMF subscribed.

@creynolds, can you please complete the form in the description? Thanks!

Needs to be checked on. This probably went out a while ago:

  • /auth/-/merge_requests/4 closed and pointed to MR8
  • /auth/-/merge_requests/8 closed and deployed.

cc @JArguello-WMF @ROdonnell-WMF

Bumping this; @JWuyts-WMF to review (slack thread)
MR4 was closed without the copy changes ever making to prod... review and see if still need those copy changes.

reviewed, copyedited, new MR opened: infrastructure/auth/ MR9. I'll ping Jackeline to reprioritize so ENG can review.
Even though this is an MR from an older branch, there don't seem to be any merge conflicts 🎉

ready for dev deploy to test. tallyho

Approved. Do you need anything other than the reveiw?

@KMontalva-WMF chuck is asking if you can deploy to dev and prod as part of on call for this ticket? if you don't have the bandwidth he'll do it when he's back next week

Done:

image.png (941×1 px, 131 KB)

There's an extra space after the username in the last line, and a missing space after "No problem.", but otherwise LGTM.

Spacing issues in copy sent up; pipeline ran.

This must be on prod now . Please check.

@SGupta-WMF signed up with new account; user created in cognito but no email was ever sent; need to dig into potential issue there.

Ticket T407427 created for the user signup issue.
Until that's fixed I cannot test this ticket. I mean it should work but can't confirm w/o email delivery.