Page MenuHomePhabricator

Fix capitalization in some ISA messages
Open, Needs TriagePublicBUG REPORT

Description

Some ISA messages have strange and inconsistent capitalization.

Here's a list I've found till now. Perhaps there are more:

First batch:

  • "Sorry %(campaign_name)s Could not be created" -> could
  • "%(campaign_name)s Campaign created!" -> campaign
  • "You need to Login to update a campaign" -> log in
  • "You cannot update this campaign, Contact Manager User:%(campaign_manager)s" -> "You cannot update this campaign. Contact the manager, User:%(campaign_manager)s"
  • "Booo! %(campaign_name)s Could not be updated!" -> could
  • "You can access information on the previous Campaigns in the Archive section." -> campaigns
  • "Below is a list of your Campaigns" -> campaigns
  • "Most improved Countries" -> countries
  • "show all metadata from commons" -> Commons
  • "Undo Changes" -> changes
  • "Caption Languages" -> languages
  • "We Are Unable to find the page you are looking for" -> "We are unable"
  • "Server Under maintenance" -> under
  • "Make it Simple: Use simple words and concepts to describe what you see in each image (e.g. cat, mountain, Taj Mahal" -> "Make it simple"

Second batch:

  • "Preferred Languages set Successfully" -> "Preferred languages set" (the word "successfully" is not really necessary)
  • "Easily Add Information about Images on Wikimedia Commons" -> "Easily add information about images on Wikimedia Commons"

It should be fairly trivial, and in many other projects I'd make a patch to fix them myself, but I'm not sure how to do it with Gettext projects. They probably need some building after changing the string, and I don't know how to do that.

Details

Related Changes in Gerrit:

Event Timeline

Change 990675 had a related patch set uploaded (by Eugene233; author: Eugene233):

[labs/tools/Isa@m2c] Fix capitalization in some ISA messages

https://gerrit.wikimedia.org/r/990675

Change 990675 merged by jenkins-bot:

[labs/tools/Isa@m2c] Fix capitalization in some ISA messages

https://gerrit.wikimedia.org/r/990675

Hey, I saw few more inconsistent capitalization in message.pot file. Can I change those in this same task or I have to create a new task for that?

It'll be better if you create a new task so as to show which messages clearly have this issue.

Eugene233 subscribed.

This needs a re-check before it is closed.Could be a good task for a new-comer contributor to the tool.

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Hi , newcomer here.... I've gone through the very few leftover inconsistencies and edited them.

isa/messages.pot
“Sorry %(campaign_name)s Could not be created” → could
“%(campaign_name)s Campaign created!” → campaign
“You need to Login to update a campaign” → log in
“You cannot update this campaign, Contact Manager User:%(campaign_manager)s” → manager
“Booo! %(campaign_name)s Could not be updated!” → could
“You can access information on the previous Campaigns in the archive section.” → campaigns
“Below is a list of your Campaigns” → campaigns
“Most improved Countries” → countries
“show all metadata from commons” → Commons
“Undo Changes” → changes
“Caption Languages” → languages
“We Are Unable to find the page you are looking for” → unable
“Server Under maintenance” → under
“Make it Simple: Use simple words...” → simple

isa/templates/main/home.html
“Your Campaigns” → campaigns

isa/campaigns/routes.py
“Sorry %(campaign_name)s Could not be created” → could
“%(campaign_name)s Campaign created!” → campaign
“You need to Login to update a campaign” → log in
“You cannot update this campaign, Contact Manager User:%(campaign_manager)s” → manager
“Booo! %(campaign_name)s Could not be updated!” → could

isa/templates/campaign/campaigns.html
“Below is a list of your Campaigns” → campaigns

isa/templates/users/own_campaigns.html
“Below is a list of your Campaigns” → campaigns

isa/templates/campaign/campaign_stats.html
“Most improved Countries” → countries

isa/templates/campaign/campaign_entry.html
“show all metadata from commons” → Commons

Pppery added a subscriber: Dagmawi-M.