Page MenuHomePhabricator

[Tooling] Restore or remove MobileFrontend storybook
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

The storybook in MobileFrontend were disabled as part of T354943. This means we are unable to run UI regression tests or review designs for the many different types of MobileFrontend components that exist. This makes it harder for us to at a later date port them to Codex equivalents.

This is also a good time to re-evaluate the value of the storybook.

We should either look to fix this or migrate away.

Details

Event Timeline

Jdlrobson renamed this task from [Tooling] Restore Popups storybook to [Tooling] Restore Popups and MobileFrontend storybooks.Jan 13 2024, 12:29 AM
Jdlrobson added a project: MobileFrontend.
Jdlrobson updated the task description. (Show Details)
Jdlrobson triaged this task as Medium priority.Jan 17 2024, 12:04 AM
Jdlrobson set the point value for this task to 3.Feb 1 2024, 6:56 PM

During estimation we discussed that Pixel seems to cover most of the things we got out of storybook so we may want to remove it and update Pixel tests to capture it.

Jon to separate out the Popups upgrade into a separate ticket.

Jdlrobson renamed this task from [Tooling] Restore Popups and MobileFrontend storybooks to [Tooling] Restore or remove MobileFrontend storybook.Feb 1 2024, 7:00 PM
Jdlrobson updated the task description. (Show Details)

Change 1010968 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/MobileFrontend@master] Remove MobileFrontend storybook

https://gerrit.wikimedia.org/r/1010968

During estimation we discussed that Pixel seems to cover most of the things we got out of storybook so we may want to remove it and update Pixel tests to capture it.

Jon to separate out the Popups upgrade into a separate ticket.

I have added the patch to remove the story book files and configuration. still If anything needed to be added to pixel, we have to point them out or put it as an expected outcome of this ticket

Change 1010968 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Remove MobileFrontend storybook

https://gerrit.wikimedia.org/r/1010968

Sign Off/Next Steps:

  • Talk about this more
  • Write a ticket about making an ADR in the repo about storybook's future

To summarise the discussion from Slack that is mostly provided by @Jdlrobson, here are the key points:

  • MediaWiki's lack of hot reloading: Noted as particularly useful during development for instant feedback, but absent in MediaWiki's workflow. The workaround involves using Storybook to observe changes in components during development.
  • Coverage by Pixel: Pixel is recognised for its comprehensive coverage of important aspects. However, gaps are acknowledged in replicating the block workflow, which presents challenges due to its complexity and because it's controlled by other teams.
  • Debate on the need for a Storybook-like tool: There's a consensus that reintroducing something akin to Storybook might not be necessary for components managed by other teams, especially for specific, complex aspects like the block workflow.
  • Push for Codex integration: Emphasised as a way to reduce the reliance on Storybook by moving more components and functionalities to Codex, thereby simplifying the development process.
  • Visibility of custom components: The inability to easily overview custom components, as is possible with Codex, is flagged as a concern, indicating a need for better management or integration strategies for these components.
  • Future plans: The discussion hints at the drafting of an Architecture Decision Record (ADR) and scheduling a Software & Hardware Design Team (SHDT) meeting to further address these topics.
  • Mobile frontend and Pixel coverage: The initial thread emphasises the need to increase Pixel mobile coverage for cases previously addressed by Storybook. This aims to identify and address gaps in Pixel's coverage, potentially leading to an ADR ticket for comprehensive documentation and action planning.
  • Next steps: Arranging the ADR and SHDT meeting, will be coordinated by @Jdrewniak.

@Jdrewniak - assuming there's no blockers for arranging the ADR and meeting (or that it's already happened), I'll go ahead and resolve this.