Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Gehel | T317045 [Epic] Re-architect the Search Update Pipeline | |||
Resolved | Gehel | T341332 [EPIC] The CirrusSearch streaming updater should support private wikis | |||
Resolved | EBernhardson | T345185 Provide a method for internal services to run api requests for private wikis | |||
Resolved | EBernhardson | T354976 Create new NetworkSession mediawiki extension | |||
Resolved | jhsoby | T356438 Add NetworkSession mediawiki extension to translatewiki.net |
Event Timeline
Change 990255 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):
[integration/config@master] Zuul: Add NetworkSession mediawiki extension
Change 990251 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):
[mediawiki/extensions/NetworkSession@master] Basic extension structure
Change 990255 merged by jenkins-bot:
[integration/config@master] Zuul: Add NetworkSession mediawiki extension
Mentioned in SAL (#wikimedia-releng) [2024-01-12T22:34:52Z] <James_F> Zuul: [mediawiki/extensions/NetworkSession] Add basic CI for T354976
FWIW MediaWiki-extensions-NetworkAuth is a similar extension, if you are interested in prior art (but it's very outdated and does not use AuthManager).
Change 990252 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):
[mediawiki/extensions/NetworkSession@master] Implement NetworkSessionProvider
Change 990251 merged by jenkins-bot:
[mediawiki/extensions/NetworkSession@master] Basic extension structure
Went through https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment to make sure we've done what's needed:
- Create an Extension:NetworkSession page on mediawiki.org - https://www.mediawiki.org/wiki/Extension:NetworkSession
- Create a Help:Extension:NetworkSession page on mediawiki.org - skipped, help pages are for "normal visitors to a wiki website" and this extension provides for internal operations only.
- Code hosting - https://gerrit.wikimedia.org/r/admin/repos/mediawiki/extensions/NetworkSession
- Issue Tracking - https://phabricator.wikimedia.org/tag/networksession/
- Stewardship - https://www.mediawiki.org/w/index.php?title=Developers/Maintainers&diff=prev&oldid=6313527
- Localization - The only localization is the extension description, unclear if necessary (or how).
- Gating deployment and feature flags - The extension does nothing on initial deployment, it only does something once configured to.
- Unit testing - unit tests cover the majority of functionality and are run by CI
- Database schema - No database changes exist
- Compatability - Light review was done of SessionProvider instances available in wmf prod, not expecting any compatability issues
- Hosting a test version - While this could be done, it seems unnecessary given there is no user visible functionality
- Code reviews - Hosted in gerrit and follows standard wmf code review policies.
Localization - The only localization is the extension description, unclear if necessary (or how).
We now have error messages that are returned, so localization is now necessary. I've filled T356438 to have the extension added to translatewiki.net
You could also implement SessionProvider::describeMessage() (or the corresponding i18n message) while you are at it. I forgot about that during code review (it isn't too important) but if you are setting up i18n anyway...
Change 990252 merged by jenkins-bot:
[mediawiki/extensions/NetworkSession@master] Implement NetworkSessionProvider
Change 1001035 had a related patch set uploaded (by Zoranzoki21; author: Zoranzoki21):
[mediawiki/extensions/NetworkSession@master] Enable Grunt tests
Change 1001035 merged by jenkins-bot:
[mediawiki/extensions/NetworkSession@master] Enable Grunt tests
Updated the mw.org page with the latest changes, so it's now inline with the repository. I think this is enough to call this ticket complete. T355267 is the task for deploying this extension to the wikis.