Page MenuHomePhabricator

Make ext-gmp and ext-bcmath required extensions in composer.json
Open, Needs TriagePublic

Description

ext-bcmath and/or ext-gmp are used by MediaWiki in various situations, but their requirement isn't enforced at runtime unless their usage is actually needed (e.g.ScrambleMapping, GlobalIdGenerator on 32 bit machines).

https://gerrit.wikimedia.org/r/990340 at least mentions them in in suggest, but it feels like we should just make them (both?) required extensions. Or at least ext-gmp, which seems to be generally preferred over ext-bcmath.

Could we then drop compat paths for bcmath?

Is there any cases/reasons we can't enforce them (going forward; the suggest should be at least backported) being necessary to run/install/update MW?

Event Timeline

Change 990340 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] composer.json Add ext-bcmath and ext-gmp to suggests

https://gerrit.wikimedia.org/r/990340

Change 990340 merged by jenkins-bot:

[mediawiki/core@master] composer.json Add ext-bcmath and ext-gmp to suggests

https://gerrit.wikimedia.org/r/990340

Change 990411 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_41] composer.json Add ext-bcmath and ext-gmp to suggests

https://gerrit.wikimedia.org/r/990411

Change 990412 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_40] composer.json Add ext-bcmath and ext-gmp to suggests

https://gerrit.wikimedia.org/r/990412

Change 990413 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] composer.json Add ext-bcmath and ext-gmp to suggests

https://gerrit.wikimedia.org/r/990413

Change 990411 merged by jenkins-bot:

[mediawiki/core@REL1_41] composer.json Add ext-bcmath and ext-gmp to suggests

https://gerrit.wikimedia.org/r/990411

Change 990413 merged by jenkins-bot:

[mediawiki/core@REL1_39] composer.json Add ext-bcmath and ext-gmp to suggests

https://gerrit.wikimedia.org/r/990413

Change 990412 merged by jenkins-bot:

[mediawiki/core@REL1_40] composer.json Add ext-bcmath and ext-gmp to suggests

https://gerrit.wikimedia.org/r/990412