Page MenuHomePhabricator
Create Task
Maniphest T355012

Mobile suppression of filter log entries does not work
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue:

  • Go to someone's list of filter log entries on mobile website
  • Select a log entry and click "change visibility of selected entries"

What happens?:

  • Log entry is struck out, but does not actually get suppressed

What should have happened instead?:

  • Log entry should have been suppressed
  • When doing this on desktop, it gives a green box confirming the suppression

Other information:

  • Issue also occurs when you open up the "details" of a single log entry and change visibility from there
  • Issue is the same both on an actual mobile using the mobile site and on a desktop device using the mobile site
  • Issue does not exist when on a mobile device using the desktop site
  • Issue does not exist for "regular" log entries

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use ::getLocalUrl instead of ::getFullUrl for HideAbuseLog formmediawiki/extensions/AbuseFiltermaster+1 -1
Customize query in gerrit

Event Timeline

Sdrqaz created this task.Jan 13 2024, 11:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2024, 11:40 PM
Dreamy_Jazz subscribed.EditedJan 14 2024, 12:10 AM

I can reproduce this on enwiki. It seems to be any state change. For example, if I was to unhide something it doesn't actually apply until I was to try using the desktop form.

It also seems to convert the view I'm using to desktop view.

Dreamy_Jazz added a comment.EditedJan 14 2024, 12:37 AM

I've worked out why this happens (I think). This is because HideAbuseLog::show sets the action URL for the form as a URL for the desktop version of the site (i.e. en.m.wikipedia.org vs en.wikipedia.org). This explains why I could not re-produce it locally and why when I submitted the form on enwiki on mobile it would take me back to desktop view.

Relevant code is at https://gerrit.wikimedia.org/g/mediawiki/extensions/AbuseFilter/+/947e437566391eb174e0c3d43da138150fd2a5ff/includes/View/HideAbuseLog.php#116

Dreamy_Jazz added a comment.Jan 14 2024, 1:00 AM

This should be fixable by changing ::getFullUrl to ::getLocalUrl, but I don't have the time to investigate further.

Thryduulf subscribed.Jan 14 2024, 8:49 AM
Dreamy_Jazz claimed this task.Jan 20 2024, 11:39 AM
gerritbot added a comment.Jan 20 2024, 11:48 AM

Change 991909 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/AbuseFilter@master] Use ::getLocalUrl instead of ::getFullUrl for HideAbuseLog form

https://gerrit.wikimedia.org/r/991909

gerritbot added a project: Patch-For-Review.Jan 20 2024, 11:48 AM
Dreamy_Jazz moved this task from Backlog to Logging on the AbuseFilter board.Jan 20 2024, 11:50 AM
gerritbot added a comment.Jan 25 2024, 12:41 PM

Change 991909 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Use ::getLocalUrl instead of ::getFullUrl for HideAbuseLog form

https://gerrit.wikimedia.org/r/991909

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 25 2024, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 25 2024, 1:30 PM
Dreamy_Jazz closed this task as Resolved.Jan 31 2024, 7:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits