TextArea: implement min-width 256px as in TextInput
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	bmartinezcalvo
	Jan 15 2024, 5:47 PM

Description

Background

We implemented the min-width @size-1600 (256px) in the following Codex components:

Combobox
Select
TextInput and ChipInput

In order to maintain consistency between TextInput and TextArea, we should apply the same min-width @size-1600 (256px) in TextArea.

Design spec

Once a component spec sheet has been created in Figma, remove the note stating that the spec is missing and link to the spec below.

Component spec sheet

Open questions

Add here the questions to be answered in order to design and implement the component

Acceptance criteria (or Done)

Design

Include the recommendation for a min-width @size-1600 (256px) in the Min/Max examples of the TextArea's Figma spec

Code

Implement the min-width @size-1600 (256px) in TextArea

Future task

Guidelines in Codex: Ensure that the information provided in the Figma spec sheet is also included in the new "Minimum and Maximum" section. This will be completed in T358859.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update Codex from 1.19.0 to 1.20.0	mediawiki/core	master	+573 -516
	styles, TextArea: Add `min-width: 256px` to TextArea component	design/codex	main	+3 -0

Customize query in gerrit

Related Objects

Mentioned Here: T358859: Figma content to Codex: Document the Guidelines for Min-Max and Best Practices
T358906: TextInput, Select, and Combobox: Reconsider min-width set

Event Timeline

bmartinezcalvo created this task.Jan 15 2024, 5:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2024, 5:47 PM

bmartinezcalvo moved this task from Inbox to Backlog on the Design-System-Team board.Jan 15 2024, 5:48 PM

We still need to do this, right? Given the outcome of T358906, the expectations for what should happen in Figma are now different.

In code, yes. In Figma, no. So maybe the acceptance criteria here just needs to be changed.

CCiufo-WMF triaged this task as Low priority.Mar 7 2024, 10:44 PM

CCiufo-WMF updated the task description. (Show Details)

CCiufo-WMF moved this task from Backlog to Up Next on the Design-System-Team board.

bmartinezcalvo updated the task description. (Show Details)Mar 8 2024, 1:45 PM

CCiufo-WMF added a project: good first task.Aug 23 2024, 7:51 PM

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

CCiufo-WMF moved this task from Up Next to Needs Refinement on the Design-System-Team board.Aug 23 2024, 7:51 PM

Prajwallokhande2003 subscribed.Dec 16 2024, 11:18 AM

Prajwallokhande2003 unsubscribed.

Can I work on this issue? Is this still open? Please provide me with the GitHub repository link as well.

@RJ2904 Sorry I forgot to ping! I've started work on this, that was my bad.

@RJ2904 Also, re: github, you can find the instructions for pulling down the codex repo in the docs here: https://doc.wikimedia.org/codex/latest/

Millipede88 changed the task status from Open to In Progress.Jan 20 2025, 2:55 PM

Change #1113174 had a related patch set uploaded (by Millmason; author: Millmason):

[design/codex@main] styles: Add min-width: 256px to TextArea component

https://gerrit.wikimedia.org/r/1113174

gerritbot added a project: Patch-For-Review.Jan 21 2025, 4:37 PM

Change #1113174 merged by jenkins-bot:

[design/codex@main] styles, TextArea: Add `min-width: 256px` to TextArea component

https://gerrit.wikimedia.org/r/1113174

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2025, 1:30 AM

Volker_E reassigned this task from RJ2904 to Millipede88.Jan 22 2025, 4:06 AM

Volker_E updated the task description. (Show Details)

Volker_E set the point value for this task to 1.

Volker_E added a subscriber: RJ2904.

Volker_E added a project: CSS.Jan 22 2025, 5:21 AM

Millipede88 closed this task as Resolved.Jan 22 2025, 1:30 PM

Only re-opening because we usually don't close the task until the patch has actually been included in a release.

Change #1113883 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from 1.19.0 to 1.20.0

https://gerrit.wikimedia.org/r/1113883

gerritbot added a project: Patch-For-Review.Jan 23 2025, 11:07 PM

Change #1113883 merged by jenkins-bot: