Page MenuHomePhabricator

Styling of AFC date picker and NPP date picker has diverged
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Novem_Linguae
Jan 15 2024, 11:10 PM
Referenced Files
F42713272: cssTask2.png
Mar 18 2024, 2:18 AM
F42713260: cssTask1.png
Mar 18 2024, 2:18 AM
F41692157: image.png
Jan 15 2024, 11:10 PM
F41692154: image.png
Jan 15 2024, 11:10 PM

Description

Steps to replicate the issue (include links if applicable):

  • Special:NewPagesFeed
  • Set filters
  • click New Page Patrol. look at date picker
  • click Articles for Creation. look at date picker

What happens?:

  • Date picker margin/padding between the two date pickers is different
  • Date picker margin/padding between the date picker group and the form elements above it is different
  • Padding between "From"/"To" and the date picker is different.

NPP:

image.png (574×344 px, 14 KB)

AFC:

image.png (528×288 px, 13 KB)

What should have happened instead?:

  • All should be consistent. Ideally by using the same classes so that style changes to one are also applied to the other.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Sushrith_Bogi updated Other Assignee, added: Sushrith_Bogi.
Sushrith_Bogi updated Other Assignee, removed: Sushrith_Bogi.

Change 1010248 had a related patch set uploaded (by Sushrith Bogi; author: Sushrith Bogi):

[mediawiki/extensions/PageTriage@master] Maintain consistency across NPP and AFC

https://gerrit.wikimedia.org/r/1010248

Test wiki created on Patch demo by MPGuy2824 using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/0a111bcb82/w

Test wiki on Patch demo by MPGuy2824 using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/0a111bcb82/w/

Change rMW1012027144bf had a related patch set uploaded (by Obamwonyi; author: Obamwonyi):

[mediawiki/extensions/PageTriage@master] Fixed diverged styling for AFC and NPP date pickers.

https://gerrit.wikimedia.org/r/1012027

Hi, I have applied a fix to this task and it worked, I have made a push, and the images are below.

cssTask1.png (640×470 px, 67 KB)

cssTask2.png (656×444 px, 57 KB)

Change #1012027 abandoned by Jsn.sherman:

[mediawiki/extensions/PageTriage@master] Fixed diverged styling for AFC and NPP date pickers.

Reason:

Fixed in I539bd9b404f6c20d7f773b67f66ba56fb17ce533

https://gerrit.wikimedia.org/r/1012027

Change #1010248 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Maintain consistency across NPP and AFC

https://gerrit.wikimedia.org/r/1010248