Difference in paragraph wrapping after transclusion end
Open, LowPublic
Actions

Assigned To

Authored By

	Arlolra
	Jan 16 2024, 1:27 AM

Description

Isolated from the rendering difference at,
https://en.wikivoyage.org/wiki/Talk:Indonesian_phrasebook#Pagebanner

Snippit,

{{1x|

}}
hello

Parsoid

<span about="#mwt1" typeof="mw:Transclusion" data-mw="{&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;1x&quot;,&quot;href&quot;:&quot;./Template:1x&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;\n\n&quot;}},&quot;i&quot;:0}}]}" id="mwAg">

</span>
<p id="mwAw">hello</p>

Legacy parser

<p><br>
</p><p>hello
</p>

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Allow paragraph inducing to happen across template start boundary	mediawiki/services/parsoid	master	+117 -104

Customize query in gerrit

Related Objects

Mentioned In: T380899: Parsoid renders "Incident status" (wikitech) incorrectly
T368719: Missing paragraph in Talk page (from visualdiff testing)

Event Timeline

Arlolra created this task.Jan 16 2024, 1:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2024, 1:27 AM

Arlolra added a project: Parsoid.Jan 16 2024, 1:27 AM

MSantos added projects: Content-Transform-Team-WIP, Parsoid-Read-Views.Jan 18 2024, 3:11 PM

MSantos moved this task from Needs Triage to Known Differences on the Parsoid board.

ssastry moved this task from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.Mar 14 2024, 3:13 PM

Change #1013380 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Difference in paragraph wrapping around transclusions

https://gerrit.wikimedia.org/r/1013380

gerritbot added a project: Patch-For-Review.Mar 21 2024, 6:02 PM

MSantos moved this task from Current Deploy Target to In Progress on the Content-Transform-Team-WIP board.Apr 29 2024, 3:21 PM

ABreault-WMF claimed this task.Apr 30 2024, 10:47 PM

MSantos moved this task from In Progress to Current Deploy Target on the Content-Transform-Team-WIP board.May 6 2024, 3:14 PM

cscott moved this task from Current Deploy Target to Code Review on the Content-Transform-Team-WIP board.Jun 3 2024, 3:24 PM

ABreault-WMF triaged this task as Medium priority.Jun 15 2024, 1:09 AM

ABreault-WMF merged a task: T303491: Edge case rendering difference with trailing newlines in templates combining with newlines at the top level.Jul 5 2024, 10:34 PM

ABreault-WMF added a subscriber: ssastry.

ABreault-WMF mentioned this in T368719: Missing paragraph in Talk page (from visualdiff testing).Jul 8 2024, 9:12 PM

MSantos moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Jul 25 2024, 1:43 PM

MSantos edited projects, added Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed Parsoid-Read-Views.

We have a patch for this, which works, but (relaying from @ABreault-WMF), "the output is unfortunate, with the usual result being that the template range is expanded undesirably, making more content uneditable. Subbu and I had concluded that it probably wasn't worth doing and I was going to close it as known differences between the parsers."

MSantos added a project: OKR-Work.Jul 29 2024, 2:46 PM

MSantos added a parent task: T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis.Aug 1 2024, 9:25 PM

MSantos closed this task as Declined.Aug 19 2024, 3:24 PM

Arlolra merged a task: T372888: P-wrapping edge case in Parsoid.Aug 20 2024, 3:36 PM

I am going to reopen this because of the discussion on the dupe task -- the patch that caused us to decline it does a slightly different thing (it looks at start of template) than what is needed (look at end of template). It is possible we arrive at the same result and decline it, but worth investigating a bit by starting off of Arlo's patch.

I had started on the end meta in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1025867

MSantos moved this task from Code Review to Backlog on the Content-Transform-Team-WIP board.Aug 26 2024, 3:20 PM

ihurbain removed a parent task: T371640: [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis.Oct 24 2024, 2:36 PM

Mr._Starfleet_Command subscribed.Jan 3 2025, 1:35 AM

ABreault-WMF mentioned this in T380899: Parsoid renders "Incident status" (wikitech) incorrectly.Feb 28 2025, 11:39 PM

SLopes-WMF added a project: Content-Transform-Team (Work In Progress).Mar 7 2025, 12:03 PM

SLopes-WMF moved this task from Backlog to Q2 FY25-26 on the Content-Transform-Team (Work In Progress) board.

MSantos moved this task from Q2 FY25-26 to Backlog on the Content-Transform-Team (Work In Progress) board.Mar 10 2025, 3:17 PM

ihurbain removed a project: Content-Transform-Team-WIP.Apr 10 2025, 1:20 PM

Alien333 subscribed.Apr 12 2025, 5:01 PM